feat: added excel backend - #334
Merged
Merged
Conversation
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Closed
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
PeterStaar-IBM
marked this pull request as ready for review
November 18, 2024 08:22
vagenas
reviewed
Nov 18, 2024
| return k | ||
| return 0 | ||
|
|
||
| def convert_workbook(self, doc: DoclingDocument) -> DoclingDocument: |
Member
There was a problem hiding this comment.
All methods that are not meant for the public API (presumably this one and various ones below), should be start with a _ as per PEP 8.
vagenas
reviewed
Nov 18, 2024
|
|
||
| return doc | ||
|
|
||
| def get_level(self) -> int: |
Member
There was a problem hiding this comment.
Is this method used somewhere? If not, let's best remove it.
vagenas
reviewed
Nov 18, 2024
Comment on lines
+257
to
+265
| return { | ||
| "beg_row": start_row, | ||
| "beg_col": start_col, | ||
| "end_row": max_row, | ||
| "end_col": max_col, | ||
| "num_rows": max_row + 1 - start_row, | ||
| "num_cols": max_col + 1 - start_col, | ||
| "data": data, | ||
| }, visited_cells |
Member
There was a problem hiding this comment.
Let's use pydantic classes instead of raw dictionaries, as this keeps way easier to maintain.
Also I think several of these keys (e.g. "beg_row", "beg_col", ...) appear to be unused.
dolfim-ibm
reviewed
Nov 18, 2024
| xlsx_path.parent.parent / "groundtruth" / "docling_v2" / xlsx_path.name | ||
| ) | ||
|
|
||
| conv_result: ConversionResult = converter.convert(xlsx_path) |
Member
There was a problem hiding this comment.
It would be interesting to test also with the bytes stream
| # Parses the DOCX into a structured document model. | ||
|
|
||
| origin = DocumentOrigin( | ||
| filename=self.file.name or "file", |
Member
There was a problem hiding this comment.
as a default, I would suggest file.xlsx
maxmnemonic
reviewed
Nov 18, 2024
| from typing import Set, Tuple, Union | ||
|
|
||
| from docling_core.types.doc import ( | ||
| DocItemLabel, |
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
maxmnemonic
previously approved these changes
Nov 19, 2024
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
maxmnemonic
approved these changes
Nov 19, 2024
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a backend to convert excel workbooks.
Resolves #258.
Checklist:
conventional commits.