build: wait for docker load progress cleanup - #4064
Open
crazy-max wants to merge 1 commit into
Open
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3948
closes #4056
--loadcan stream Docker import progress after the solve has already started cleaning up. When that happens, the import goroutine can still write to the build progress printer while the printer is being closed, which can panic withsend on closed channel.This fixes the lifecycle ordering by joining the Docker load writer during solve cleanup, before the command waits on the printer. It also makes the load writer close path safe when BuildKit never opened the writer, so cleanup can always call it without hanging.
I took this over from #4056 because the original PR mixed the correct lifecycle fix with a broader
Printer.Writerecovery path. Catchingsend on closed channelwithrecoverwould hide progress writer ownership bugs globally and make the printer contract weaker than it needs to be.