Skip to content

build: parallelize forced reference evaluation #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonistiigi merged 1 commit into from
Mar 9, 2026
Merged

build: parallelize forced reference evaluation #3696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion build/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opts map[
return nil, err
}
} else if forceEval {
if err := res.EachRef(func(ref gateway.Reference) error {
if err := eachRefParallel(ctx, res, func(ctx context.Context, ref gateway.Reference) error {
return ref.Evaluate(ctx)
}); err != nil {
return nil, err
Expand Down Expand Up @@ -1321,6 +1321,24 @@ func solve(ctx context.Context, c gateway.Client, req gateway.SolveRequest) (*ga
return res, nil
}

func eachRefParallel(ctx context.Context, res *gateway.Result, fn func(context.Context, gateway.Reference) error) error {
var refs []gateway.Reference
if err := res.EachRef(func(ref gateway.Reference) error {
refs = append(refs, ref)
return nil
}); err != nil {
return err
}

eg, ctx := errgroup.WithContext(ctx)
for _, ref := range refs {
eg.Go(func() error {
return fn(ctx, ref)
})
}
return eg.Wait()
}

func catchFrontendError(retErr, frontendErr *error) {
*frontendErr = *retErr
if errors.Is(*retErr, ErrRestart) {
Expand Down