Skip to content

[URP-738] - Check your answers fixes - #651

Open
ByronVernon wants to merge 3 commits into
mainfrom
fix/urp-738/cya-fixes
Open

ByronVernon wants to merge 3 commits into
mainfrom
fix/urp-738/cya-fixes

Conversation

@ByronVernon

Copy link
Copy Markdown
Contributor

URP-738 - Check your answers fixes

Summary

Updates Check your answers (CYA) and the task list to match the URP-738 rules:

  • Service readiness is optional. Its unanswered questions no longer raise errors or block submit, and an untouched task shows one "Not yet provided" row with "Edit section".
  • PIM and EAMS are hidden for a biosimilar through a new AnswerNotIn page condition. CYA explains why, and the task list shows "Cannot start yet" with no link.
  • CYA also gets the "(optional)" titles, a "Hidden" tag on the record title and a secondary "Return to my records" button. A group with no items is no longer tagged with an error.

Screenshots / Evidence

Risks and follow-up

  • The 12-month "becomes mandatory" rule (scenarios 8-10) is not included. It needs a market authorisation date on the record.
  • "Hidden" and the optional section ID are hard-coded on the frontend until the backend sends them.
  • Before technology status is answered, CYA also reports the required PIM question, while the task list shows "Cannot start yet".
  • There is no test that an invalid answer given in an optional section is still reported. No service readiness question has a rule beyond Required or options today.
  • A biosimilar's PIM/EAMS shows "Cannot start yet" on the task list (team decision). The design said "Not applicable".

Checklist

  • Tests added or updated where appropriate
  • Linting and formatting pass
  • Accessibility considered for UI changes
  • Security/privacy impact considered
  • Documentation updated where needed

Before you post it:

  • Tick Linting and formatting only after pnpm lint:check and just pass.
  • Tick Accessibility if you've checked the new "Hidden" tag and the "Edit section" link text. The link has visually hidden text for the task title.
  • Replace the screenshots line with real images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant