fix: don't tear down IP assignments when guest.net is empty but tools report running - #3
Merged
Merged
Conversation
…tive IP removal Old TMOS builds (e.g. BIG-IP 11.5.0, 12.1.4.1) report VMware Tools as running but never populate per-NIC guest.net data. That caused every interface's NetBox IP assignment on those VMs to look "removed" on each sync cycle and get deleted, even though the guest is up and the IP is still live. Skip IP handling for a VM when guest.net comes back completely empty while tools report running; a real per-NIC removal still reports the NIC (just without an IP), so that case is unaffected.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guestToolsRunningbut never populate per-NICguest.netdata. Every sync cycle, this looked like "all IPs removed from all interfaces" and netbox-sync deleted the (correct, live) IP-to-interface assignments.skip_ip_handlingguard (previously only triggered when tools aren't running at all) to also skip IP add/remove for a VM whenguest.netcomes back completely empty despite tools reporting running.guest.net, just with no IP bound to it, soskip_ip_handlingstaysFalseand the removal still happens.Test plan