Skip to content

Fix CI nightly's mismatched_lifetime_syntaxes - #364

Merged
sebcrozet merged 1 commit into
dimforge:masterfrom
ThierryBerger:fix-nightly-lifetime
Jul 23, 2025
Merged

sebcrozet merged 1 commit into
dimforge:masterfrom
ThierryBerger:fix-nightly-lifetime

Conversation

@ThierryBerger

@ThierryBerger ThierryBerger commented Jul 17, 2025 •

Copy link
Copy Markdown
Contributor

Current master has warnings on nightly due to a bunch of mismatched_lifetime_syntaxes:

warning: lifetime flowing from input to output with different syntax can be confusing
  --> crates/parry3d/../../src/partitioning/bvh/bvh_traverse.rs:79:44
   |
79 |     pub fn leaves<F: Fn(&BvhNode) -> bool>(&self, check_node: F) -> Leaves<F> {
   |                                            ^^^^^                    --------- the lifetime gets resolved as `'_`
   |                                            |
   |                                            this lifetime flows to the output
   |
   = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
   |
79 |     pub fn leaves<F: Fn(&BvhNode) -> bool>(&self, check_node: F) -> Leaves<'_, F> {
   |

@ThierryBerger
ThierryBerger requested a review from sebcrozet July 17, 2025 08:38
@sebcrozet
sebcrozet merged commit a998e5f into dimforge:master Jul 23, 2025
@sebcrozet

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants