Skip to content

fix: make period a required field for uptime alert - #828

Merged
danaelhe merged 2 commits into
digitalocean:mainfrom
mikesmithgh:fix/uptime-alert-period-required
Oct 9, 2023
Merged

fix: make period a required field for uptime alert#828
danaelhe merged 2 commits into
digitalocean:mainfrom
mikesmithgh:fix/uptime-alert-period-required

Conversation

@mikesmithgh

Copy link
Copy Markdown
Contributor

Hi, I am working digitalocean/doctl#1419 as part of #hacktoberfest and discovered period is not defined as a required field in the spec.

If I attempt to post a request without period then I receive

{
    "id": "Internal Server Error",
    "message": "Server Error"
}

The field is also required on the UI.
uptime-alert-screenshot

@danaelhe

danaelhe commented Oct 9, 2023

Copy link
Copy Markdown
Member

GREAT catch! Will merge on green 🚀 thank you!

@danaelhe danaelhe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants