Skip to content

BUG: The nap skill keeps a size limitation #123

Closed

Description

@diberry
Image

Activity

  1. added
    squadSquad triage inbox — Lead will assign to a member
    on Mar 30, 2026
  2. github-actions commented on Mar 30, 2026

    @github-actions

    🏗️ Squad Triage — Flight (Lead)

    Issue: #123 — Big: The nap skill keeps a size limitation
    Assigned to: Flight (Lead)
    Reason: No specific domain match — assigned to Lead for further analysis

    @copilot evaluation: No strong capability match — routed to squad member.

    Team roster:

    • Flight (Lead) → label: squad:flight
    • Procedures (Prompt Engineer) → label: squad:procedures
    • EECOM (Core Dev) → label: squad:eecom
    • FIDO (Quality Owner) → label: squad:fido
    • PAO (DevRel) → label: squad:pao
    • CAPCOM (SDK Expert) → label: squad:capcom
    • CONTROL (TypeScript Engineer) → label: squad:control
    • Surgeon (Release Manager) → label: squad:surgeon
    • Booster (CI/CD Engineer) → label: squad:booster
    • GNC (Node.js Runtime) → label: squad:gnc
    • Network (Distribution) → label: squad:network
    • RETRO (Security) → label: squad:retro
    • INCO (CLI UX & Visual Design) → label: squad:inco
    • GUIDO (VS Code Extension) → label: squad:guido
    • Telemetry (Aspire & Observability) → label: squad:telemetry
    • VOX (REPL & Interactive Shell) → label: squad:vox
    • DSKY (TUI Engineer) → label: squad:dsky
    • Sims (E2E Test Engineer) → label: squad:sims
    • Handbook (SDK Usability) → label: squad:handbook
    • Ralph (Work Monitor) → label: squad:ralph
    • @copilot (Coding Agent) → label: squad:copilot

    To reassign, remove the current squad:* label and add the correct one.

  3. changed the title [-]Big: The nap skill keeps a size limitation[/-] [+]BUG: The nap skill keeps a size limitation[/+] on Mar 30, 2026
  4. added a commit that references this issue on Mar 31, 2026
    e2151f9
  5. diberry commented on Mar 31, 2026

    @diberry
    OwnerAuthor

    Ralph Status Update — Issue #123

    Status: Fix implemented and upstream PR opened

    Step Status
    Root cause Budget calc missed newline separator bytes during reassembly
    Fork PR diberry/squad#131
    Team Reviews All 19 squad members posted reviews — all approved
    Upstream PR bradygaster/squad#726
    Upstream Merge Waiting for upstream maintainer

    Root cause: archiveDecisions() budget calculation didn't account for join('\n') separators and header/trailing newlines added during content reassembly. This caused recentContent to exceed DECISION_THRESHOLD even after archival, triggering repeated size limitation enforcement.

    Fix: Added reassemblyOverhead (2 bytes) and +1 byte per entry for join separators. All 42 nap tests pass.

    Will close this issue when upstream PR github#726 is merged.

  6. diberry commented on Mar 31, 2026

    @diberry
    OwnerAuthor

    🛰️ Ralph — P0 Status Update

    Issue: #123 — nap skill keeps a size limitation
    Status: 🟡 Fix exists as draft PR
    PR: #92 (draft) — fix(nap): heading-aware archival

    Progress

    • PR fix(nap): heading-aware archival #92 exists but is still a draft — excluded from PR lifecycle pipeline
    • The fix adds heading-aware archival to nap.ts:
      • Parses ## section boundaries (not just ### entries)
      • Preserves ## section headings when child ### entries are kept
      • Groups archived entries under their parent section headings
      • 2 new tests for section-aware archival
    • Changes: packages/squad-cli/src/cli/core/nap.ts + test/nap.test.ts

    Next Steps

    • PR needs to be marked ready for review (un-draft) to enter the pipeline
    • Once un-drafted, Ralph will label it squad:pr-needs-review on next round

    Ralph — Work Monitor

  7. added 7 commits that reference this issue on Mar 31, 2026
    0dcae09
    42a601f
    386e74b
    8967018
    69cc665
    cc23cc5
    bdfa21a
  8. diberry commented on Apr 5, 2026

    @diberry
    OwnerAuthor

    Closing: work completed upstream or no longer relevant. See diberry/project-dina#22 cleanup audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggo:needs-researchNeeds investigationpriority:p0Blocking releasesquadSquad triage inbox — Lead will assign to a membersquad:flightAssigned to Flight (Lead)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions