fix(hub-ui): retry failed client scripts - #374
Conversation
◈ PR Lens
Architecture 1 component touched across 2 lanes. Data flow
Drill down
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, localized, and directly covered by an added integration test that exercises the new retry behavior.
Pull request overview
This PR updates the hub-ui dock client-script setup caching so that a failed client-script setup doesn’t permanently block future activations of the same dock entry, aligning behavior with the hub UI’s “activate to try again” workflow.
Changes:
- Clear the cached setup promise for non-action dock entries when the setup promise rejects, allowing subsequent activations to retry setup.
- Add an integration test that simulates a failing client script on first activation and verifies setup is retried successfully on a later activation.
File summaries
| File | Description |
|---|---|
| packages/hub-ui/src/client/state/setup-script.ts | Ensures failed non-action client-script setup promises are removed from the cache so later activations can retry. |
| packages/hub-ui/src/client/state/client-script.integration.test.ts | Adds coverage proving a failed client-script setup is retried on subsequent dock activation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Retry client-script setup on a later dock activation after a failure.
Found this while working on a model for eager activation of client scripts. The fix seemed reasonable so I'm submitting as a different PR