Skip to content

fix(inspect): show agent invoke parsing errors - #373

Merged
antfu merged 1 commit into
mainfrom
fix/inspect-agent-invoke-errors
Sep 9, 2026
Merged

fix(inspect): show agent invoke parsing errors#373
antfu merged 1 commit into
mainfrom
fix/inspect-agent-invoke-errors

Conversation

@posva

@posva posva commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

currently clicking the invoke button with malformed json does nothing

Copilot AI lite review requested due to automatic review settings September 8, 2026 14:24
@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 8, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~1 changed · 🔴 -0 removed · 1 flow · 1 file · commit 498f1ff


Architecture

Architecture diagram for devframes/devframe at 498f1ff

1 component touched across 3 lanes.

Open the interactive canvas


Data flow

Data flow diagram for devframes/devframe at 498f1ff

Agent tool argument validation and invocation

Open the interactive canvas


Drill down
Built-in Devframes — 1 component
🟡 CHANGED Inspect Devframe

Devframe plugin providing inspection UI and tools for inspecting runtime state, functions, and agent manifests.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail
  • Show unchanged neighbours

Tip

Would you rather run it from CI on a key of your own? Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and a model key in your repository secrets, say GEMINI_API_KEY. The Action asks Gemini by default, or OpenAI and any endpoint speaking /chat/completions through its provider input.

🪧 More tips
  • Run PR Lens on your own machine: npx skills add coldteadotai/pr-lens installs the agent skill. Then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Draw a diff before it is even a pull request: npx @coldtea/pr-lens-cli analyze --base origin/main reads the diff with your own model key, and npx @coldtea/pr-lens-cli render .pr-lens/graph.json draws the same lenses on your machine.
  • The boxes under View are live. Tick Architecture lens or Data flow lens to choose which diagrams appear, or Expand every detail to open every drill-down at once. The comment redraws in place a few seconds later.
  • Show unchanged neighbours lists the components this change did not touch alongside the ones it did, so the drill-down shows what the changed code sits next to.
  • GitHub will not let you zoom an image in a comment. The link under each diagram opens it on an interactive canvas, where you can zoom, pan and step through the flow.
  • The CLI's render picks up .github/pr-lens.yml automatically and applies your corrections (renames, exclusions, lane pins) at draw time.
  • PR Lens is free for open source. A star on the repository is what keeps it going.
  • Push a new commit and the whole comment re-renders for the new head. An older run never overwrites a newer one, so a slow render cannot put a stale diagram back.
  • The diagrams follow your GitHub theme, so dark mode gets the dark render and light mode the light one, and the moving dots show this pull request's data in motion.

◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Come say hi on Discord

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
devframe Skipped Skipped Sep 8, 2026 2:25pm UTC

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new error element id generation is based on a lossy tool-name transform and can create duplicate DOM ids, breaking the intended aria-describedby association.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR improves the Inspect devframe’s Agent tab by surfacing malformed JSON argument parsing errors inline, tying them to the arguments textarea for accessibility, and clearing the error state on edits or successful parses.

Changes:

  • Added per-tool parsing error state (invokeErrors) and changed invocation to report JSON parse failures inline instead of throwing.
  • Improved textarea accessibility with aria-invalid and aria-describedby, and added an inline error alert UI via FeedbackTip.
File summaries
File Description
plugins/inspect/app/components/AgentView.vue Adds inline JSON parse error reporting and accessibility wiring for the Agent tool invocation textarea.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +50 to +52
function invokeErrorId(id: string): string {
return `agent-invoke-error-${toAgentToolName(id)}`
}
@posva

posva commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Actually, we could redo this view completely with better async state handling, filters, auto discovery of values, etc

@antfu
antfu merged commit be28778 into main Sep 9, 2026
14 of 15 checks passed
@antfu
antfu deleted the fix/inspect-agent-invoke-errors branch September 9, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants