test(hub-ui): cover collapsed edge logo positions - #365
Conversation
◈ PR Lens
Architecture 1 component touched across 3 lanes. Data flow No data-flow sequence changed in this PR. Drill down
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is isolated to Storybook stories and cleanly expands fixture coverage without affecting runtime code paths.
Pull request overview
Adds Storybook visual fixtures for collapsed edge docks on the left and right positions, strengthening regression coverage for the dock-edge logo orientation behavior in @devframes/hub-ui.
Changes:
- Introduced a shared
collapsedEdgeStory()helper for edge-mode “idle-collapsed” fixtures. - Refactored the existing
CollapsedIdlestory to use the helper. - Added new
CollapsedLeftandCollapsedRightstories to cover both vertical dock-edge positions.
File summaries
| File | Description |
|---|---|
| packages/hub-ui/src/client/components/dock/DockEdge.stories.ts | Refactors collapsed-edge Storybook setup into a helper and adds left/right collapsed fixtures for visual coverage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Background (Why)
Collapsed edge docks need explicit visual fixtures for both vertical positions. The logo orientation fix is already on
mainin0.9.12, but the existing Storybook coverage only exercised the bottom edge.Changes (What)
Add
CollapsedLeftandCollapsedRightstories through a shared collapsed-edge story helper. The existing bottom fixture remains available asCollapsedIdle, and the floatingMinimizedstory continues to cover the upright floating logo.Verification (Testing)
ESLint and the
@devframes/hub-uitypecheck pass. The Storybook production build completes and includes both new stories. Matched browser checks against the parent of the logo fix show the left and right logo wrapper changing from a 270-degree transform to no transform; the floating minimized logo remains upright.