[dezren39]

Problem

turbo.json defined 11 #test tasks twice (#145). Turbo's JSONC parser silently keeps the last definition, so the first (transit) block was dead config: 8 of the tasks actually ran with dependsOn: ["^build"] and 3 (http-recorder, theme, util) with no dependsOn at all — losing even the transit hash-folding the file's own comment describes.

Fixes #145

Solution — deliberate choice: restore transit

The transit block is the newer, intended definition: commit 1fc489d878 added it together with the comment "Workspace packages export their sources, so tests never wait for a dependency's build … No package has a transit script: it runs nothing and only folds every workspace dependency into the test hash" — and left the older block behind it. Every other #test task in the file already uses transit (exceptions are single, deliberate ones: protocol ^build, schema/desktop none).

So this PR deletes the trailing duplicate block (41 lines) and keeps the transit definitions. This is an intentional behaviour change, not a neutral dedup:

turbo run test --dry=json before → after (76 → 65 tasks in graph):

• @opencode/client#test: ^build deps (3 builds) → @opencode/client#transit
• @opencode/gui-extensions#test: 6 #build deps → own transit
• @opencode/plugin#test: 6 #build deps → own transit
• @opencode/plugin-browser#test, @opencode/plugin-github#test, @opencode/merman#test: #build deps → own transit
• @opencode/sdk#test: 9 #build deps → @opencode/sdk#transit (which itself folds all 9 workspace transit deps)
• @opencode/simulation#test: 5 #build deps → own transit
• @opencode/http-recorder#test, @opencode/theme#test, @opencode/util#test: [] → own transit (cache hash now folds workspace dependencies again)
• The 11 packages' #build tasks leave the test graph entirely — tests no longer wait for dependency builds, per the file's stated intent. No other task's graph changes.

Guard

• New script/turbo-json.test.ts: a duplicate-aware JSONC scan (tracks every object's keys in the raw text; comments and string contents never count) asserting turbo.json defines every key exactly once, plus two self-tests for the scanner.
• Wired into CI in test.yml's unit job next to the existing mcpx-cleanup script step (same script/ pattern as test(script): mcpx-cleanup.test.ts is run by nothing — no CI job, turbo task, or package script executes it #138), so a repeat fails CI on both OS legs.

Verification

• Duplicate-aware scan on the fixed file: 32 #test keys, 32 unique, 0 duplicates (was 43/32/11).
• bun test turbo-json.test.ts (from script/): 3/3 pass.
• Ablation: with the pre-fix turbo.json restored, exactly the real-file test fails (listing the duplicates); with the fix, 3/3 pass.
• turbo run test --dry=json succeeds before and after; graph diff above.
• Prettier clean on all touched files; test.yml YAML parses.

Single-repo: no turbo.json exists in developing-today/code, developing-today/openchamber, or dezren39/nix (checked), so no cross-repo set is owed.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 16587895-c847-4d1c-8592-c1a9387d7319

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad01b8 and 1be5614.

📒 Files selected for processing: 3

• .github/workflows/test.yml
• script/turbo-json.test.ts
• turbo.json

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-20T16:07:42.214854Z	1be5614	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 72 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate: