Repository navigation
fix(aggregator): dated Meta charge incidents + truthful Meta blocked note (charges 22.89 → 42.89) - #994
Merged
Conversation
extractCharges only knew the 2026-10-25 two-charge pattern and hard-coded its two rows, so the 2026-10-26 $20 METAPAY charge (Citi Costco ending 9545) recorded in both the provider registry and quota-view could never reach the charges table (stuck at $122.89). Add a dated-incident pass over both established record formats, deduped on date+amount+card, each row with its own date and payment method. Total is now $142.89 against the real records. extractMeta: a dated 402 billing_not_configured read now outranks the past-reset early return and walls the pool WITH a truthful note (blocked-status mapping, not measured consumption) instead of a bare walled/100% with note: null. Tests: companion cases in usage.test.ts (single incident, deduped across both records) and quota.test.ts (blocked read after the reset). Full suite 126 pass, tsc clean.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the dashboard /quota truth fix. extractCharges was structurally unable to emit any Meta charge beyond the hard-coded 2026-10-25 pair; it now iterates dated single-charge incidents in both established record formats (registry billing-incident bullets + quota-view 'Newer dated charge' records), deduped on date+amount+card. extractMeta gains a billing-blocked branch: a dated 402 billing_not_configured read walls the pool with a truthful note instead of note: null. Verified against the real quota-view/registry: 5 charge rows totaling $142.89 incl. 2026-10-26 $20.00 Citi Costco •9545; Meta walled with the blocked note; Go pools unchanged (80%/62%). Full suite 126 pass, tsc clean.
Need help on this PR? Tag
@codesmith-botwith what you need.