Repository navigation
fix(aggregator): collector egress proxy env (projects section was silently omitted under the systemd unit) - #992
Merged
Merged
Conversation
Under the fleet-feed-collector systemd unit's minimal env, the collector ran with no proxy: its Bitwarden fetch (GitHub Project token) and api.github.com GraphQL read both failed fail-soft, so the projects section (#910 stage 5) was silently omitted from every unit-produced feed. Export the same proxy credential the push uses (env only, never argv — #948) plus NO_PROXY for loopback/tailnet reads, before invoking the collector. Verified: clean-env run (env -i, HOME pinned) produces 'projects 27 items' and pushes; push-fleet-feed.guard.sh passes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the fleet-feed-collector unit's minimal env, push-fleet-feed.sh ran the collector before any proxy was configured: the collector's Bitwarden fetch (github.project-token) and GitHub GraphQL read failed fail-soft, omitting the #910 stage-5 projects section from every unit-produced feed. This exports the same proxy credential the push already uses (env only, never argv, per #948) plus NO_PROXY for loopback/tailnet reads, before the collector runs. Guard script passes; clean-env end-to-end run yields 'projects 27 items' and a successful push.
Need help on this PR? Tag
@codesmith-botwith what you need.