[dezren39]

Problem

/today returned HTTP 500 while /api/today.json worked. The orchestrator publishes orchestration.json with each goal's progressedSinceLastRun as a single string, but the aggregator declared/consumed it as string[]:

• todayFromSection (src/derive.ts) passed it straight into ProjectMomentum.accomplished
• renderToday (src/render.ts) called (m.accomplished ?? []).map(...) on the string → TypeError → the HTML render path crashed

Fix (aggregator side only; the publisher side is handled separately)

• src/derive.ts — boundary normalization in todayFromSection via a new asStringList() helper: an array stays a list (entries via String()), a non-empty string becomes [string], anything else becomes []. This is the only place progressedSinceLastRun is consumed (verified by grep — the only other accomplished producer, deriveToday's board path, already builds a real string[]), so downstream consumers can trust the shape.
• src/render.ts — renderToday defensively coerces a non-array accomplished (wraps it, entries via String()) so a TodayView built outside the derive boundary can never crash rendering again.

Tests

• test/slice2.test.ts: two regression tests in the existing today-view suite —
  1. a section whose goal has progressedSinceLastRun as a string produces a TodayView with accomplished == [that string] and renderToday renders it under "Recently accomplished";
  2. renderToday given a TodayView with a bare-string accomplished renders instead of throwing.
• Targeted run: bun test test/slice2.test.ts test/orchestration.test.ts — 23 pass, 0 fail.
• bun run typecheck (tsc --noEmit) — clean.

Note for local runs: the fixtures import pm-stack/grist/seed/roadmap.json, so the sparse checkout needs pm-stack/grist alongside pm-stack/aggregator for the slice2 tests to load.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T16:48:26.709714Z	a70291e	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}