Skip to content

fix(id-web): truncate file-list tag values on a char boundary (fixes #815) - #820

Merged
dezren39 merged 1 commit into
mainfrom
creator/815-tag-truncate-boundary
Oct 25, 2026
Merged

fix(id-web): truncate file-list tag values on a char boundary (fixes #815)#820
dezren39 merged 1 commit into
mainfrom
creator/815-tag-truncate-boundary

Conversation

@dezren39

@dezren39 dezren39 commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #815

Problem

render_file_list in pkgs/id/src/web/templates.rs truncated long tag-pill values with &v[..256], which panics (byte index 256 is not a char boundary) when byte 256 splits a multi-byte UTF-8 character in a user-controlled tag value — taking down the file-list render for any list containing such a tag. Reproduced verbatim on main: "a"×255 + "é" + "tail…" panics with it is inside 'é' (bytes 255..257).

Fix

Use the crate's existing boundary-safe helper crate::commands::tag::truncate_on_char_boundary (the CLI's helper, whose own tests already cover this exact straddle shape) instead of the inline slice. It returns the value unchanged when it fits, so behaviour for ≤256-byte and pure-ASCII values is identical.

Tests

  • New regression test test_render_file_list_tag_value_straddling_truncation_boundary: renders a file list with a 269-byte tag value whose é straddles byte 256; asserts no panic and the pill shows the value truncated on the boundary with ….
  • The panic itself was reproduced on main's exact code shape with a verbatim rustc harness (&v[..256] on the straddling value → byte index 256 is not a char boundary; it is inside 'é' (bytes 255..257)); with the fix, the new test passes.

Local verification

  • Full web::templates suite on this branch: 32 passed, 0 failed (cargo test --features web --lib web::templates::), including the new regression test and test_render_editor_escapes_filename.
  • rustfmt --check clean on the changed file.
  • Note: local sandbox linking of the id test binary is memory-constrained (ld OOM on earlier attempts; succeeded with -Wl,--no-keep-memory and CARGO_BUILD_JOBS=2).

Muse (new-issue-creator)
fix(id-web): truncate file-list tag values on a char boundary (#815)
db68517 
render_file_list sliced &v[..256] to truncate long tag-pill values,
which panics when byte 256 splits a multi-byte UTF-8 character in a
user-controlled tag value. Use the crate's existing
truncate_on_char_boundary helper (commands::tag) instead, and add a
regression test with an é straddling byte 256.
@dezren39
dezren39 requested a review from a team as a code owner October 24, 2026 22:51
@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7385af82-15ab-46eb-9b17-5d0a282e6ef7
Commits

Reviewing files that changed from the base of the PR and between 1161bcf and db68517.

Files selected for processing: 1
  • pkgs/id/src/web/templates.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T22:53:19.361103Z db68517 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39 dezren39 mentioned this pull request Oct 24, 2026
Closed
@dezren39

dezren39 commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Sweep review (2026-10-24): the red nix flake check on this PR was not this change — its only failing checks were test-web/test-web-typecheck, both from the pre-existing goto-line.test.ts TS2345 errors on main (run 40140357862; all other checks ✅, incl. test/test-unit). That main bug is now fixed and merged via #822 (fixes #821, merge fa68786). This PR's own change was locally verified by the creator run: templates suite 32/32 PASS incl. the new regression test. Merging per the standing directive; post-merge main CI validates the combined result.

@dezren39
dezren39 merged commit 10f9240 into main Oct 25, 2026
4 of 5 checks passed
@dezren39
dezren39 deleted the creator/815-tag-truncate-boundary branch October 25, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dezren39 dezren39

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

id(web): file-list tag pill truncation panics on a multi-byte character straddling byte 256 — templates.rs slices &v[..256] off-boundary

1 participant

@dezren39