Repository navigation
lab-ops-hub: RCDATA/raw-text parity for textarea, iframe, xmp, noembed, noframes (#4008) - #5228
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4008.
Worker-fallback
extractHtml(pkgs/lab-ops-hub/src/lib.ts) now mirrors the container Extractor's HTMLParser modes for the five elements issue #4008 names:</textarea>, and it contributes body text. The reported case<textarea><script></textarea><p>Article body</p>now yields<script> Article body, identical to the container (the Worker returned empty text).feed()(container/app.py never callsclose()), so an unclosed raw-text/RCDATA tail stays unflushed and is dropped; the Worker now drops it too for these five elements. Script/style/title EOF handling is unchanged.Fixtures: 10 new container-verified cases in
test/extractor-fixtures.json(the reported example plus at least one per element, an entity-verbatim case, both unclosed cases, and a trailing-attribute close tag), each generated from the container Extractor and pinned in both suites.One clarification vs the issue text: the acceptance says iframe/xmp/noembed/noframes content is "skipped" — container-verified behavior is that the content is skipped as markup (never parsed for tags/links) but delivered as literal text; the fixtures encode the verified behavior.
Tests (laptop, this branch):
npm run test:ts— 99 pass, 0 fail.test_extractor_parity.py— OK (all 39 fixtures, both directions).npm run test:py— 69 tests, 1 pre-existing error intest_container_validate(test_returns_idn_hosts_in_alabel_form, IDNA judging in container/app.py under Python 3.14; that code is untouched by this diff and the deployed container pins Python 3.13).Queue: task 8964, lane code-n.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.