Repository navigation
test(id): track shell contract revision 5 in the conformance message check (#5020 follow-up) - #5168
Merged
Merged
Conversation
![developing-today[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…check (#5020) PR #5159 bumped the shell contract revision 4 -> 5 (the contract's own rule for additive changes); the conformance message formats v{version}.{revision} from the live contract, so the hard-coded v1.4 expectation in the_contract_check_reports_conformance_or_every_violation went red. Update the literal to v1.5.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5020 / PR #5159.
#5159 bumped the shell contract
revision4 -> 5 (additive change, per the contract's own rule). The conformance message is formatted from the live contract (v{version}.{revision}), so the hard-codedv1.4expectation incommands::world::tests::the_contract_check_reports_conformance_or_every_violationwent red on main. This updates the literal tov1.5— nothing else.Verified on the laptop: the named test passes.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.