Skip to content

fix(mcpx): match Go duration spellings (#3490) - #4841

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/6931-3490-goduration-parity
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/6931-3490-goduration-parity

Conversation

@dezren39

@dezren39 dezren39 commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Summary

- (\d+(?:\.\d+)?)(ns|us|µs|ms|s|m|h)
+ ((?:\d+(?:\.\d*)?|\.\d+))(ns|us|µs|μs|ms|s|m|h)

Keeps the required-unit check, so bare 5. remains invalid. Updates the canonical plugin and its identical .opencode dogfood copy; adds parity coverage for .5s, 1.s, compound fractions, microsecond spellings, and rejected forms.

Evidence

  • bun test pkgs/mcpx/plugin/opencode/mcx/daemon.test.ts — 25 passed.
  • bun test ./.opencode/plugin/mcx/daemon.test.ts — 25 passed.
  • Go 1.26.8 time.ParseDuration cross-check confirms the accepted and rejected examples.
  • git diff --check and copy comparison — clean.

Merge Danger

Door: two-way.

Blast Radius: low — duration parsing in the MCPX OpenCode plugin and its mirrored dogfood copy; deliberate negative, malformed, and int64 ceiling behavior remains unchanged.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 3, 2026 10:08
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T10:08:03.627005Z
We couldn’t complete this review. Comment @codex review to try again.
cbe1286 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9acb86c9-9ecf-441e-b75b-3923213324a8
Commits

Reviewing files that changed from the base of the PR and between 1e3763f and cbe1286.

Files selected for processing: 4
  • .opencode/plugin/mcpx/daemon.test.ts
  • .opencode/plugin/mcpx/daemon.ts
  • pkgs/mcpx/plugin/opencode/mcpx/daemon.test.ts
  • pkgs/mcpx/plugin/opencode/mcpx/daemon.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant