Skip to content

fix(id): refuse replication feeds after storage failure (#4724) - #4738

Merged
dezren39 merged 1 commit into
mainfrom
queue/6705-4724-replication-snapshot-storage-failure
Nov 3, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/6705-4724-replication-snapshot-storage-failure

Conversation

@dezren39

@dezren39 dezren39 commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Closes #4724

Summary

  • Refuse new replication feeds once world storage has failed, so a complete but unconfirmed journal entry cannot be sent in a signed snapshot.
  • Publish ResetFailed to existing subscribers when a failed append changed the journal header version.
  • Add a regression that writes a complete newline-terminated entry before simulating sync_data failure, then verifies new feeds reject it.

Verification

  • cargo test --manifest-path pkgs/id/Cargo.toml --lib --no-default-features --features world replication_feed_tests -- --nocapture — 4 passed
  • Rustfmt 1.99.0 check and git diff --check — passed

Receiver/verifier changes under #806 are out of scope.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39 dezren39 added app/id Package/app: id (pkgs/ or apps/ in this repo) kind/bug Something isn't working (prefixed form of the classic bug label) labels Nov 3, 2026
@dezren39
dezren39 requested a review from a team as a code owner November 3, 2026 02:33
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5d4066bd-efd0-49da-a730-d4411360f502
Commits

Reviewing files that changed from the base of the PR and between d504a94 and 8e3573b.

Files selected for processing: 1
  • pkgs/id/src/world/actor.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T02:35:26.116120Z 8e3573b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit cf74b1e into main Nov 3, 2026
1 check passed
@dezren39
dezren39 deleted the queue/6705-4724-replication-snapshot-storage-failure branch November 3, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app/id Package/app: id (pkgs/ or apps/ in this repo) kind/bug Something isn't working (prefixed form of the classic bug label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

id(world-replication): new feeds can receive a snapshot containing a storage-failed, never-durable mutation (PR #4589)

1 participant