Skip to content

fix(aggregator): allowlist github-result URLs to https://github.com/ (#950) - #4599

Merged
dezren39 merged 1 commit into
mainfrom
queue/6484-950-githuburl-allowlist
Nov 3, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/6484-950-githuburl-allowlist

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Fixes #950 (queue task 6484).

POST /api/comments/github-result accepted any string as url; CommentsStore.markGithubResult stored it verbatim and the dashboard renders it as a link href — a stored javascript: URL became a clickable script link.

  • pm-stack/aggregator/src/comments.ts: markGithubResult rejects any result url not matching ^https://github\.com/ (state unchanged; the endpoint already maps the throw to a 400). Single write-path choke point — covers the endpoint and direct store callers.
  • pm-stack/aggregator/test/slice3.test.ts: store-level test (javascript:/data:/http:/wrong-host URLs refused, pending state + no githubUrl; real github.com URL still posts) + endpoint test (javascript: URL → 400).

Verified: bun test test/slice3.test.ts — 34 pass, 0 fail.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39 dezren39 added kind/security Security issue or security hardening app/aggregator Package/app: aggregator (pm-stack in this repo) app/pm-stack pm-stack (Pad/Grist) in developing-today/code labels Nov 2, 2026
@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 21:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T21:51:16.917861Z 7ff55cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb9c6ce8-f820-465d-ad33-49c94de94759
Commits

Reviewing files that changed from the base of the PR and between 5bf164b and 7ff55cb.

Files selected for processing: 2
  • pm-stack/aggregator/src/comments.ts
  • pm-stack/aggregator/test/slice3.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

🤖 Agent note · awaiting-ci (parked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app/aggregator Package/app: aggregator (pm-stack in this repo) app/pm-stack pm-stack (Pad/Grist) in developing-today/code kind/security Security issue or security hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security(aggregator): comment githubUrl is stored unvalidated and rendered as a link href — a javascript: URL reaches the dashboard

1 participant