Skip to content

fix(aggregator): align project config validation (#3766) - #4538

Merged
dezren39 merged 2 commits into
mainfrom
queue/6229-3766-project-config-ref-validation
Nov 3, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/6229-3766-project-config-ref-validation

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

- validate tracked refs with a broader local regex
+ validate tracked refs through model.parseRef
- check openIssuesAsOf shape only
+ require YYYY-MM-DD shape and a real calendar date

Closes #3766.

Evidence

  • Before: a/b/c#12 and 2026-02-30 were accepted by validateProjectConfigs.
  • After: bun test test/program.test.ts — 16 pass, 271 assertions.
  • git diff --check origin/main...HEAD passes. bun run typecheck reports pre-existing diagnostics also present on clean main; none are in the changed files.

Merge Danger

Door: Two-way. Blast Radius: Narrow — registry validation and regressions only.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 18:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T18:55:55.209011Z fed8ae8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cfc80e09-97ad-4921-9f45-a7e0bf697089
Commits

Reviewing files that changed from the base of the PR and between 02a3b95 and fed8ae8.

Files selected for processing: 2
  • pm-stack/aggregator/src/project-config.ts
  • pm-stack/aggregator/test/program.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@dezren39
dezren39 merged commit eef89b9 into main Nov 3, 2026
2 checks passed
@dezren39
dezren39 deleted the queue/6229-3766-project-config-ref-validation branch November 3, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant