Skip to content

fix(chat): preserve broadcast order with bounded recipient queues - #4530

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/6421-4389-chat-broadcast-order
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/6421-4389-chat-broadcast-order

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

app.send
  serialize broadcast enqueue order
  enqueue to each program FIFO (1 in-flight + up to 16 queued)
    full queue → remove stalled recipient
ProgramHandler Wait
  remove program and stop its dispatcher

Delivery is enqueued rather than called inline, so Update can broadcast to its own program without blocking.

Evidence

  • Before: the fail-first ordering probe recorded [second, third, first]; 100 broadcasts to one blocked recipient added 100 goroutines.
  • After: the ordering probe confirms both recipients receive the same sequence; the stalled-recipient probe confirms queue overflow prunes the recipient without per-broadcast goroutine growth; self-send is delivered once per update in order without blocking Update.
  • go test ./... -count=1 — pass (pkgs/chat).
  • go test -race ./... -count=1 — pass (pkgs/chat).
  • go vet ./... and git diff --check — pass.

Merge Danger

Door: two-way.

A slow recipient is removed once its fixed 16-message queue fills; other recipients continue receiving broadcasts.

Blast Radius: chat sessions only.

Closes #4389.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 18:42
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 333e75df-9051-4a8e-8af9-60ca9709ce9e
Commits

Reviewing files that changed from the base of the PR and between 0ea90ec and 8a12197.

Files selected for processing: 2
  • pkgs/chat/main.go
  • pkgs/chat/main_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T18:44:21.637173Z 8a12197 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chat: broadcast fan-out runs each Send in its own goroutine — messages arrive out of order and a stalled session piles up unbounded blocked goroutines

1 participant