[dezren39]

Fixes #4133.

Problem

reconcile in pkgs/id/src/currency_poc/recovery.rs counted matches per leg entry and compared matched == record.legs.len():

• an empty leg vector satisfied the check vacuously (0 == 0) → persisted Posted / returned AlreadyPosted with zero transfers;
• a duplicated leg ID counted one distinct ledger transfer once per entry → [t, t] with only t posted was reported fully posted.

Change (confined to currency_poc)

• recovery.rs: before any lookup, a record whose leg vector is empty or repeats a transfer ID is reported ReconcileOutcome::Inconsistent and left unresolved. Module doc records the malformed-vector disposition.
• tests.rs: two regression tests — recovery_rejects_empty_leg_vector (both Resubmit and Abandon policies) and recovery_rejects_duplicate_leg_ids_backed_by_one_transfer.

Verification

The id lib does not compile on current main for an unrelated reason (#4454: references.rs E0277+E0597, fix queued as queue task 6359), so the module was verified standalone: a probe crate containing the verbatim currency_poc module from this branch ran the full scenario suite on the laptop — 17 passed, 0 failed, 1 ignored (pre-existing harness smoke test), including both new tests and all existing recovery tests (recovery_does_not_trust_transfer_id_existence_alone, crash-recovery scenarios). Once #4454 lands, cargo test -p id --lib currency_poc should be re-run on main.

Queue: task 6048 (repo-health-code-pilot), lane code-h.

---

^{Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: be5b663d-33b9-4cf1-bc48-600a5fb9704a

Commits

Reviewing files that changed from the base of the PR and between 997ee1d and 023ff40.

Files selected for processing: 2

• pkgs/id/src/currency_poc/recovery.rs
• pkgs/id/src/currency_poc/tests.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-02T17:04:33.175500Z	023ff40	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.