Repository navigation
Conversation
HTTPTransport.Send's first-value decode-failure path read the rest of a 2xx body unbounded and pushed the whole body as one message. Cap the tee-buffered head and the rest read at defaults.HTTPErrorBodyLimit so oversized non-JSON 200 bodies are truncated, never buffered whole. Small non-JSON bodies still pass through whole; valid JSON and SSE paths are untouched. Regression tests: oversized/small non-JSON, empty body, large valid JSON, SSE. Refs #4282
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4282.
HTTPTransport.Send's first-value decode-failure fallback read the rest of a 2xx body with unbounded io.ReadAll and pushed the whole body as one message. The tee-buffered head and the rest read are now capped so head + rest total at most defaults.HTTPErrorBodyLimit (4KB) before push. Reused the existing named limit from the non-2xx path rather than adding a new default.
Behavior:
Tests (pkgs/mcpx, this laptop): new http_fallback_bound_test.go covers oversized/small/empty non-JSON, large valid JSON, and SSE. Verified the oversized case fails on pre-fix code and passes with the fix. go test ./internal/mcpclient/ -count=1 passes; new tests also pass under -race -shuffle=on -count=5.
Need help on this PR? Tag
@codesmith-botwith what you need.