Skip to content

fix(chat): treat server shutdown as clean stop - #4328

Open
dezren39 wants to merge 2 commits into
mainfrom
queue/5673-3209-chat-clean-shutdown
Open

dezren39 wants to merge 2 commits into
mainfrom
queue/5673-3209-chat-clean-shutdown

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

Start
  start ListenAndServe goroutine -> buffered error channel
  on SIGINT/SIGTERM -> Shutdown (30s) -> accept ssh.ErrServerClosed
  on genuine serve/shutdown error -> report once from Start

This removes the shared-error race and keeps fatal handling out of the serving goroutine. Adds focused lifecycle tests for clean signal shutdown and a bind failure.

Evidence

  • Before (triage reproduction): intentional shutdown emitted ssh: Server closed and exited 1 before the drain completed.
  • After: cd pkgs/chat && go test ./..., go test -race ./..., go build ./..., and go vet ./... all pass.

Merge Danger

Door: two-way

Blast Radius: low

Only pkgs/chat server startup/shutdown handling changes; the 30-second drain and signal set are unchanged.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 10:53
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d07a07fd-86a6-4876-ba5f-dd38af5d336a
Commits

Reviewing files that changed from the base of the PR and between 8c5c816 and 2217de5.

Files selected for processing: 2
  • pkgs/chat/main.go
  • pkgs/chat/main_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T10:55:53.208516Z 2217de5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant