Skip to content

fix(aggregator): sanitize optional registry feed - #4196

Merged
dezren39 merged 2 commits into
mainfrom
queue/5361-2539-registry-sanitize
Nov 2, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/5361-2539-registry-sanitize

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

loadFeed
  sanitize optional registry with isSessionRecord
  registry() and coverage() receive the same safe rows
  • Absent registry stays absent; non-array sections become empty, malformed rows are dropped individually, and registryDropped records losses.
  • Add loadFeed and live-source regressions for string/object/number/[null] plus a valid Muse record.

Evidence

  • Before: malformed registry containers/rows reached consumers; coverage() could throw on a non-array or null entry.
  • After: bun test test/feed.test.ts test/orchestration.test.ts test/registry-hygiene-2408.test.ts — 72 pass, 0 fail (273 assertions); git diff --check passes.
  • bun run typecheck could not run because @types/bun is absent from the installed dependencies (TS2688).

Merge Danger

Door: two-way

Blast Radius: low

Only the optional feed registry is normalized at loadFeed; other feed sections and the collector contract are unchanged.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 05:12
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41d1f514-172c-47a9-ba1c-fefe44a2fcf1
Commits

Reviewing files that changed from the base of the PR and between 082f5ba and 9031231.

Files selected for processing: 3
  • pm-stack/aggregator/src/feed.ts
  • pm-stack/aggregator/test/feed.test.ts
  • pm-stack/aggregator/test/orchestration.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T10:19:37.592811Z 9031231 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…try-sanitize

# Conflicts:
#	pm-stack/aggregator/src/feed.ts
#	pm-stack/aggregator/test/feed.test.ts
@dezren39
dezren39 merged commit d7b6e8a into main Nov 2, 2026
1 of 3 checks passed
@dezren39
dezren39 deleted the queue/5361-2539-registry-sanitize branch November 2, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant