Skip to content

fix(aggregator): sanitize malformed PAYG feed rows (#2450) - #4195

Merged
dezren39 merged 1 commit into
mainfrom
queue/5338-2450-sanitize-payg-lines
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/5338-2450-sanitize-payg-lines

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

isFleetFeed (unchanged; PAYG remains optional)
  loadFeed
    validate PAYG line fields
    keep valid rows, drop malformed rows
    expose paygDropped when anything was discarded

Fixes #2450.

Evidence

  • Before: new regression cases failed on the baseline; [null] survived loadFeed and renderQuota threw on accruedUsd.
  • After: bun test test/feed.test.ts test/charges-feed-gate.test.ts — 49 pass; bun test test/quota-contract.test.ts — 9 pass.
  • bun test test/usage.test.ts has an unrelated “Pace projections” assertion failure, reproduced on clean main. bun run typecheck has existing dependency/test typing failures, also present on clean main.

Merge Danger

Door: two-way

Blast Radius: low — validation is added only at the feed-loading boundary; collector and consumers are unchanged.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 05:12
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cfd2c963-d184-49d8-9734-7b4c726856f5
Commits

Reviewing files that changed from the base of the PR and between 199a7d2 and 78ffd9a.

Files selected for processing: 2
  • pm-stack/aggregator/src/feed.ts
  • pm-stack/aggregator/test/feed.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T05:13:35.311523Z 78ffd9a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit 58ea183 into main Nov 2, 2026
1 of 2 checks passed
@dezren39
dezren39 deleted the queue/5338-2450-sanitize-payg-lines branch November 2, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aggregator(feed): isFleetFeed never checks payg — one malformed line crashes usage() and /quota

1 participant