Skip to content

fix(aggregator): quarantine malformed comments and actions records - #4151

Merged
dezren39 merged 1 commit into
mainfrom
queue/5246-2347-quarantine-malformed-records
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/5246-2347-quarantine-malformed-records

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

load store
  validate each historical record
  if invalid rows exist
    archive exact original bytes + index/reason diagnostics
    persist only validated rows
  if archive fails
    reject load; do not permit writes

Also retain valid row- and envelope-level extension fields, and keep legacy records without optional comment state or action client tokens readable. Closes #2347.

Evidence

  • Before: mixed valid/malformed rows could throw during sorting, be silently discarded, or be rewritten without preserving the audit source.
  • After: bun test test/store-corrupt.test.ts test/store-concurrency.test.ts test/actions.test.ts test/api-health-comments.test.ts test/comments-queue-1210.test.ts — 46 passed, 0 failed. Exact original bytes, per-index diagnostics, valid-row persistence, and archive failure are covered.
  • The unrelated slice3.test.ts:508 route assertion also fails on clean main; aggregator typecheck has existing errors outside the changed files.

Merge Danger

Door: two-way

Blast Radius: aggregator

A malformed store now fails closed if its quarantine cannot be preserved, preventing subsequent writes from overwriting unread audit history.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 03:18
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2318c56d-f918-4e9a-91c6-878990f51f4f
Commits

Reviewing files that changed from the base of the PR and between ac77716 and 46c5e6d.

Files selected for processing: 4
  • pm-stack/aggregator/src/actions.ts
  • pm-stack/aggregator/src/comments.ts
  • pm-stack/aggregator/src/store-recovery.ts
  • pm-stack/aggregator/test/store-corrupt.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T03:20:36.817654Z 46c5e6d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

🤖 Agent note · parked

@dezren39
dezren39 merged commit 15af52b into main Nov 2, 2026
1 of 2 checks passed
@dezren39
dezren39 deleted the queue/5246-2347-quarantine-malformed-records branch November 2, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant