Skip to content

fix(projector): validate PORT and GitHub App install ID - #4106

Merged
dezren39 merged 1 commit into
mainfrom
queue/5209-2172-projector-config-validation
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/5209-2172-projector-config-validation

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

- Number(PORT ?? 7801)
+ parsePort(PORT) // decimal digits, 1–65535, before DB migration

- Number(GITHUB_APP_INSTALL_ID)
+ validate present value as a positive safe decimal integer
+ keep absent/empty discovery and plain-token fallbacks

Add focused validation tests without changing the existing projector API or Phase 2 scope. Fixes #2172.

Evidence

  • Before: Number() accepted coercible forms or silently treated malformed installation IDs as unset.
  • After: bun test test/config.test.ts test/github.test.ts — 14 passed; bun test — 59 passed, 0 failed.

Merge Danger

Door: two-way

Blast Radius: narrow

Only projector startup configuration and GitHub installation-token resolution change; invalid explicit configuration now fails early with the variable and offending value.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 01:14
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 37bf8e23-1049-4cfc-b95e-d453c2e9562d
Commits

Reviewing files that changed from the base of the PR and between d963623 and 77f3d69.

Files selected for processing: 5
  • pm-stack/projector/src/config.ts
  • pm-stack/projector/src/github.ts
  • pm-stack/projector/src/index.ts
  • pm-stack/projector/test/config.test.ts
  • pm-stack/projector/test/github.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T01:16:12.254097Z 77f3d69 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant