Repository navigation
docs(id): record Phase 11 completion status and audit (#312) - #404
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f4f16d928
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | **F11.8** | Benchmarks | **Planned** | Tracked in roadmap | Replay, append/fsync, and fan-out benchmarks with committed baselines. | | ||
| | **F11.9** | Bytes per frame | **Planned** | Tracked in roadmap | Measure full-screen frame sizes at 80x24 and 200x60 across examples. | | ||
| | **F11.10** | Split large modules | **Planned** | Tracked in roadmap | Split `world.rs` (6,120 lines), `world_session.rs` (4,017 lines), and `cli.rs` (3,958 lines). Unblocked now that platform stack has landed. | | ||
| | **F11.11** | One client projection | **Done** | [PR #250](https://github.com/developing-today/code/pull/250), [PR #256](https://github.com/developing-today/code/pull/256) | Seed redacted in snapshot/history (#250); single `project_event_for` projection with `history` scope (#256). Host events (#242) open. | |
There was a problem hiding this comment.
This row marks F11.11 Done even though its note says the host-event work in #242 remains open, while the simultaneously updated roadmap keeps “One place decides what a client may see” in Now as in-progress and links it to F11.11 and #242. Recording the task as complete prematurely makes this audit and its progress summary understate the remaining Phase 11 work.
Useful? React with 👍 / 👎.
| - **Completed Tasks (6)**: F11.1 (relay kit), F11.4 (fast lane), F11.6 (fuel budgets), F11.11 (client projection), F11.14 (cheaper screen), and F11.12 initial fail-loud check (#244). | ||
| - **In Progress Tasks (3)**: F11.2 (Firefox E2E), F11.3 (LogSync flakes / #255), F11.16 (replay fixtures / #239). | ||
| - **Planned / Next Tasks (9)**: F11.5 (injected time), F11.7 (host metrics), F11.8 (benchmarks), F11.9 (frame bytes), F11.10 (split large modules), F11.12 (journal CLI), F11.13 (error codes), F11.15 (smaller modules), F11.17 (view trap resilience), F11.18 (pinned toolchain). |
There was a problem hiding this comment.
The table currently contains five Done, three In Progress, and ten Planned tasks, but this summary reports 6/3/9 and counts F11.12 both as completed here and as planned below. As a result, the headline status cannot be reconciled with the per-task audit; recalculate these totals after correcting the task statuses.
Useful? React with 👍 / 👎.
| | **F11.7** | Host metrics & tracing | **Planned** | Tracked in roadmap | Actor queue depth, command latency, and Prometheus metrics endpoint. | | ||
| | **F11.8** | Benchmarks | **Planned** | Tracked in roadmap | Replay, append/fsync, and fan-out benchmarks with committed baselines. | | ||
| | **F11.9** | Bytes per frame | **Planned** | Tracked in roadmap | Measure full-screen frame sizes at 80x24 and 200x60 across examples. | | ||
| | **F11.10** | Split large modules | **Planned** | Tracked in roadmap | Split `world.rs` (6,120 lines), `world_session.rs` (4,017 lines), and `cli.rs` (3,958 lines). Unblocked now that platform stack has landed. | |
There was a problem hiding this comment.
These sizes are stale values from an earlier revision: at the reviewed commit, world.rs, world_session.rs, and cli.rs contain 7,596, 4,180, and 4,126 lines respectively, not 6,120, 4,017, and 3,958. Because the document claims to audit the state after the platform stack landed and these figures scope F11.10, retaining the pre-merge counts materially understates the split work.
Useful? React with 👍 / 👎.
| | **F11.11** | One client projection | **Done** | [PR #250](https://github.com/developing-today/code/pull/250), [PR #256](https://github.com/developing-today/code/pull/256) | Seed redacted in snapshot/history (#250); single `project_event_for` projection with `history` scope (#256). Host events (#242) open. | | ||
| | **F11.12** | Journal format management | **Planned** | [Issue #227](https://github.com/developing-today/code/issues/227) | Pre-fix fail-loud rollback check landed in #244. Version header and `check`/`backup` CLI planned. | | ||
| | **F11.13** | Error taxonomy | **Planned** | Tracked in roadmap | Stable typed wire error codes for capability errors. | | ||
| | **F11.14** | Cheaper `Screen` | **Done** | [PR #248](https://github.com/developing-today/code/pull/248) | `Screen.render_rows_json` reduces territory full-house (8 seats) view fuel from 7.1M to 1.6M (16% of 10M budget). | |
There was a problem hiding this comment.
The 7.1M baseline was measured for one seat with one cell, not for a full eight-seat territory; the checked-in full-house workload trapped after exhausting the 10M limit, while 1.6M is the post-change full-house measurement. The feature record also shows that rebuilding with the pinned compiler accounts for a substantial portion of the reduction, so this row cannot attribute a 7.1M-to-1.6M full-house reduction solely to render_rows_json; use comparable before/after workloads and preserve the compiler contribution.
Useful? React with 👍 / 👎.
|
|
||
| See the original [Phase 11 plan](phase-11-foundations.md), the [architecture record](../../doc/2026-10-17T15-00-00Z_architecture_next_stage_platform/2026-10-17T15-00-00Z_architecture_next_stage_platform.md), and the [`id` roadmap](../../planning/roadmaps/id.md). | ||
|
|
||
| This document audits the completion status of all eighteen Phase 11 tasks (F11.1 to F11.18) following the merge of the platform stack (#209 to #256) into `main`. The original plan file remains untouched per the documentation protocol. |
There was a problem hiding this comment.
The repository's planning documentation says implementation plans are maintained as steps land; only dated records under doc/ are immutable, while older .opencode/plans files remain in place merely to preserve existing links. Treating the Phase 11 plan as untouchable creates a second status source and leaves planning/plans/README.md explicitly saying its status lines lag and are tracked by the now-closed #312. Update the original maintained plan, or formally supersede and catalog it, rather than relying on this uncatalogued sidecar.
Useful? React with 👍 / 👎.
| | **F11.13** | Error taxonomy | **Planned** | Tracked in roadmap | Stable typed wire error codes for capability errors. | | ||
| | **F11.14** | Cheaper `Screen` | **Done** | [PR #248](https://github.com/developing-today/code/pull/248) | `Screen.render_rows_json` reduces territory full-house (8 seats) view fuel from 7.1M to 1.6M (16% of 10M budget). | | ||
| | **F11.15** | Smaller modules | **Planned** | Tracked in roadmap | `wasm-opt -Os` and strip integration in example `build.sh` scripts. | | ||
| | **F11.16** | Replay self-check | **In Progress** | [PR #239](https://github.com/developing-today/code/pull/239) | `id world record` and `replay` fixtures with record-match verdicts landed; determinism check planned. | |
There was a problem hiding this comment.
PR #239 added fixture recording and a single replay that compares its output with records captured from the live world, but F11.16 specifically requires id world verify to replay a journal twice and detect divergence from a nondeterministic guest. No world verify command or double-replay test exists, this row itself says the determinism check is still planned, and the roadmap also lists F11.16 as planned; marking the task In Progress therefore overstates work on the actual self-check.
Useful? React with 👍 / 👎.
Closes #312
Summary
Audits the completion status of all eighteen Phase 11 tasks (F11.1 to F11.18) following the merge of the platform stack (#209 to #256).
.opencode/plans/phase-11-foundations.mduntouched per documentation protocol..opencode/plans/2026-10-20_phase-11-status.mdwith states and PR links for every task.planning/roadmaps/id.mdto link the status record in Done.Need help on this PR? Tag
@codesmith-botwith what you need.