Repository navigation
design(id): #2819 native-spill write lease protocol - #3857
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbbbf44a00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Adds
doc/2026-11-01_design_id2819.md: recommends a journal-resident lease, DO-only grant/control authority, atomic epoch fencing, both handoffs, expiry/recovery behavior, compaction-safe audit state, invariants, acceptance criteria, and the three phased implementation packets already listed on #2819.Evidence
WorldJournal::appendtakes only aJournalEntryand has no fencing context (pkgs/id/src/world/mod.rs:685-696); the file journal fsyncs each append (pkgs/id/src/world_store.rs:177-197).git diff --checkpassed. Docs-only; no implementation tests run.Merge Danger
Door: Two-way — this is a design record and can be revised before implementation.
Blast Radius: Low — no runtime behavior changes. The protocol depends on implementing and testing the DO's serialized append/fencing gate before enabling native spill.
Need help on this PR? Tag
@codesmith-botwith what you need.