Skip to content

design(id): #2819 native-spill write lease protocol - #3857

Merged
dezren39 merged 2 commits into
mainfrom
design/id-2819
Nov 2, 2026
Merged

dezren39 merged 2 commits into
mainfrom
design/id-2819

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

DO lease + journal append gate  <── fenced appends ──  native executor
             │                            epoch + operation ID + position
             └── fsync before acknowledgment

Adds doc/2026-11-01_design_id2819.md: recommends a journal-resident lease, DO-only grant/control authority, atomic epoch fencing, both handoffs, expiry/recovery behavior, compaction-safe audit state, invariants, acceptance criteria, and the three phased implementation packets already listed on #2819.

Evidence

  • Before: WorldJournal::append takes only a JournalEntry and has no fencing context (pkgs/id/src/world/mod.rs:685-696); the file journal fsyncs each append (pkgs/id/src/world_store.rs:177-197).
  • After: the note specifies the append gate, journal positions and lease records, failure walkthroughs, and implementation tests.
  • Verification: git diff --check passed. Docs-only; no implementation tests run.

Merge Danger

Door: Two-way — this is a design record and can be revised before implementation.

Blast Radius: Low — no runtime behavior changes. The protocol depends on implementing and testing the DO's serialized append/fencing gate before enabling native spill.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 17:08
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7454008c-0af2-4f73-9af1-fe832aec48c2
Commits

Reviewing files that changed from the base of the PR and between 3c3c585 and c7456d4.

Files selected for processing: 1
  • doc/2026-11-01_design_id2819.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T17:11:34.289569Z dbbbf44 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbbbf44a00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread doc/2026-11-01_design_id2819.md Resolved
@dezren39
dezren39 merged commit 92de2af into main Nov 2, 2026
1 check passed
@dezren39
dezren39 deleted the design/id-2819 branch November 2, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant