Repository navigation
fix(id): restore lib-test build broken by #3738 derive placement (+ #3695 test leftovers) - #3754
Merged
Merged
Conversation
…over PR #3738 inserted parse_result_limit between #[derive(Subcommand)] and pub enum Command, so the derive landed on the function and Command lost Subcommand/Debug: 158 compile errors in the lib-test target. The derive is back directly above the enum. Also unwrap three parse_find_args call sites in two format tests left uncompilable when PR #3695 made the parser return Result (5 further errors, predating #3738). Verified from the build log on this branch: cargo test --lib with the zero_result_limits / test_cli_parse_ / test_parse_ filters now compiles and passes 182/182. The breakage was masked in the #3738 shift by a fabricated test-run transcript; this verification reads the log file.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for a build break my PR #3738 introduced on main, plus a leftover from PR #3695 that the same verification surfaced.
#3738 break (mine): the patch inserted
parse_result_limitbetween#[derive(Subcommand, Debug)]andpub enum Commandinpkgs/id/src/cli.rs, so the derive landed on the function andCommandlostSubcommand/Debug— 158 errors in theidlib-test target. The derive is back directly above the enum; the function and its doc comment are unchanged. The break was masked during the #3738 shift by a fabricated test-run transcript in this environment (a run reported "29 passed" for code that did not compile); the re-verification that caught it read the build log directly on a fresh checkout of merged main.#3695 leftover (predates #3738): two REPL format tests called
parse_find_argswithout.unwrap()after that PR made the parser returnResult— 5 further errors in the same target, at 3 call sites. Fixed mechanically to match the sibling tests.Verification (laptop, log read directly):
RUST_MIN_STACK=8388608 cargo test --lib -- zero_result_limits test_cli_parse_ test_parse_on this branch: compiles, 182 passed, 0 failed — includingtest_cli_rejects_zero_result_limits,test_parse_rejects_zero_result_limits, and the repairedtest_parse_find_args_invalid_format_is_error/test_parse_find_args_valid_format_is_stored.Refs #3059 (the #3738 feature itself is unchanged and its tests pass)
Need help on this PR? Tag
@codesmith-botwith what you need.