[dezren39]

Fixes #1732 · queue task 4789

What

DirectoryAuth::issue_code now sweeps expired pending codes before issuing: self.codes.retain(|_, pending| pending.expires_at > now) — the same shape as the existing session sweep in open_session. Previously an expired code for an address that never came back stayed in the per-world codes map forever (until restart); check_code only ever removed the addressed record.

Properties preserved

• All unexpired codes are retained, including ones that have run out of attempts, so resend throttling (CODE_RESEND_MS) and the 5-attempt limit behave exactly as before.
• Exact TTL boundary matches check_code: a code is expired at expires_at <= now, and the sweep retains only expires_at > now — pinned by a test at now + CODE_TTL_MS - 1 (kept) and now + CODE_TTL_MS (evicted).
• No change to code TTL, resend window, attempt cap, or digest storage (packet scope exclusions).

Cost / limits (documented in the issue_code doc comment)

The sweep is opportunistic — it runs only on issuance, so nothing is reclaimed while the world is idle and there is no hard cardinality bound. HashMap::retain scans the whole map, so issuance costs O(pending codes); accepted because issuance is already rate-limited per address. This wording follows task 1957's triage guidance — no idle cleanup or hard bound is claimed.

Tests

New in-module tests in pkgs/id/src/directory_auth.rs:

• issuing_for_another_address_evicts_expired_codes_at_the_ttl_boundary
• the_sweep_keeps_unexpired_codes_even_after_their_attempts_run_out

Targeted run cargo test --lib directory_auth (pkgs/id) is executing on the laptop under heavy parallel fleet load; result will be posted here when it lands. CI on main is the backstop.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: b3f1a918-77ca-4fa9-a7e6-d8fe0b8a87b2

Commits

Reviewing files that changed from the base of the PR and between 3cd23c7 and 4299cf0.

Files selected for processing: 1

• pkgs/id/src/directory_auth.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-01T15:20:07.051573Z	4299cf0	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[dezren39]

Verification update (queue task 4789): the first cargo test --lib directory_auth run surfaced a pre-existing compile break on main (pkgs/id cli.rs, filed as #3751, fix in PR #3757). On the combined tree (current main + PR #3757 + this PR), the targeted tests now pass: cargo test --lib directory_auth — 15 passed, 0 failed (including the two new tests: TTL-boundary eviction and exhausted-attempts retention). Logs: laptop /tmp/test-4789c.log.