Skip to content

fix(aggregator): validate survey answers by question type - #3742

Merged
dezren39 merged 1 commit into
mainfrom
queue/4772-1486-survey-answer-validation
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/4772-1486-survey-answer-validation

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

-check single/yesno only when options exist
+validate yesno exactly as yes/no
+require strings for single/text
+require published option ids for multi

Adds regression coverage for invalid and valid survey answers; preserves the #1451 partial-submit allowance.

Closes #1486.

Evidence

  • Before: new regression returned null for yesno "banana" (36 passed, 1 failed).
  • After: bun test test/needs-user.test.ts — 37 passed.
  • Full aggregator suite: 882 passed; one unrelated registry fixture failure in test/slice3.test.ts, reproduced on clean main.
  • bun run typecheck has existing failures in push.ts and unrelated test files, reproduced on clean main.

Merge Danger

Door: two-way

Blast Radius: low — POST-boundary validation only.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 15:07
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dca91eff-9fe7-425c-80be-8e3107deebcc
Commits

Reviewing files that changed from the base of the PR and between 5fa0650 and 5382c62.

Files selected for processing: 2
  • pm-stack/aggregator/src/tier-items.ts
  • pm-stack/aggregator/test/needs-user.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T15:08:26.788572Z 5382c62 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit 3757dc2 into main Nov 2, 2026
1 check passed
@dezren39
dezren39 deleted the queue/4772-1486-survey-answer-validation branch November 2, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aggregator: yes/no survey answers are never validated — any string (or even an array) is accepted as a yes/no answer

1 participant