[dezren39]

Problem → solution

Mirror port of the fix for dezren39/darwin-nix#193 (origin issue for this cross-repo mcpx set; no per-repo issue filed here, per the one-issue-per-set rule).

Bus.SubscribeFrom replayed retained history (1024 by default) into the 256-event subscriber buffer with non-blocking sends while holding the bus lock, so a replay over 256 events silently dropped the rest with no gap reported. Reproduced identically in this copy: 300 published events → 256 received, Dropped=44, gap=false.

Fix: collect the replay under the lock, size the channel for the whole replay plus the usual live buffer, and set gap if a replay send ever still cannot land. Regression test TestAReplayLargerThanTheSubscriberBufferMissesNothing (300-event replay, all in order, zero dropped) fails pre-fix and passes post-fix.

Scope: the replay half of the origin issue; live-burst drop visibility (approach C) still depends on the #6 gap contract and remains open on the origin issue.

Verified: internal/events, internal/daemon, internal/pool suites green locally; gofmt/vet clean; files byte-identical to the dezren39/nix companion PR.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-19T11:44:45.804655Z	2b12fb3	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0c34c854-0f3b-4956-aa61-f24f46b0a196

📥 Commits

Reviewing files that changed from the base of the PR and between 52f8f26 and 2b12fb3.

📒 Files selected for processing: 2

• pkgs/mcpx/internal/events/events.go
• pkgs/mcpx/internal/events/events_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}