Repository navigation
fix(cloudflare-export): reject non-decimal measurement strings - #3488
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99df3a8ff6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…decimal option Codex P2 on PR #3488: firstSum applied integer-only string validation to totalNeurons, rejecting plain-decimal fractional neuron strings (e.g. 4114515.31) that the numeric fixture accepts. firstSum now takes an integerString option (default true, counts unchanged); the ai totalNeurons call site passes false so PLAIN_DECIMAL applies. Regression coverage: fractional neuron string parses to the same metric, drifted spellings still throw unparseable naming ai.totalNeurons.
|
🤖 Codex disposition — task 4021, lane E resume The single Codex P2 finding on the original head (99df3a8) — "Allow fractional decimal strings for neuron measurements" ( Verification, re-checked fresh this shift:
Merging under the standing merge criteria. |
Summary
Closes #2791
Evidence
Number("")→ 0,Number("0x10")→ 16,Number("1e2")→ 100, and fractional request-count strings were accepted.node --test pm-stack/cloudflare-export/cloudflare-quota-export.test.mjs— 19 passed.Merge Danger
Door: two-way
Blast Radius: low — validation of string inputs at existing measurement call sites only.
Need help on this PR? Tag
@codesmith-botwith what you need.