Skip to content

fix(meta-exporter): range-check quota epoch timestamps (#2460) - #3446

Merged
dezren39 merged 2 commits into
mainfrom
queue/5340-2460-meta-epoch-range
Nov 1, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/5340-2460-meta-epoch-range

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Fixes #2460.

Summary

parseSubscriptionQuota
  resetField(window/weekly) ─┐
  as_of                    ─┴─ finite + epoch-seconds range check
                               2020-01-01 .. 2100-01-01 UTC
                               then iso()

Out-of-window values now raise ExportError("unparseable", 6). Missing resets on zero-usage windows and empty as_of remain unchanged.

Evidence

  • Before: the new regression test failed: window_resets_at=1577836799 was accepted.
  • After: node --test pm-stack/meta-exporter/meta-quota-export.test.mjs — 18/18 pass, including ms-scale, pre-2020, out-of-Date-range, and inclusive-boundary cases.

Merge Danger

Door: Two-way.

Blast Radius: Narrow — only Meta subscription-quota timestamp parsing.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 09:21
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d904d503-e770-43f8-9f5d-b4678f8d40c3
Commits

Reviewing files that changed from the base of the PR and between fde46cb and 984154a.

Files selected for processing: 2
  • pm-stack/meta-exporter/meta-quota-export.mjs
  • pm-stack/meta-exporter/meta-quota-export.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T09:22:41.881309Z 984154a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant