Repository navigation
aggregator(feed): deep quota validation — gate burn/choices, drop malformed pools/windows at loadFeed (#2429, slice 2a of #2578) - #3070
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42ce7aa49f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Slice 2(a) of #2578 (Phase 2 of #2576), quota side of the feed gate — fixes #2429.
What
isFleetFeednow requires the full section-levelQuotaViewshape the renderers dereference:burnpresent as an array andchoiceswith its three string arrays. A feed missing them (old-collector shape) is rejected whole and falls back to fixtures like other invalid feeds, instead of crashing /quota onview.burn.map.feed.ts:isQuotaWindow,isQuotaPool(a non-arraywindowsfails the pool — it can never be iterated as a collection of windows, which fabricated attention flags),isBurnSegment.loadFeedsanitizes the gate-passed quota section viasanitizeQuotaView, built on the sharedarrayOfdrop-and-count primitive from aggregator: Phase 1 of #2576 — validate.ts primitives, the ingest contract in the README, and the malformed-input probe matrix #2577 (slice 1): malformed pools and burn segments drop individually, malformed windows drop out of their pool (credential-row windows too), and the counts ride out on the returned feed asquotaDropped— surfaced, never swallowed. Every loadFeed consumer (live source, server) now sees only renderer-safe pools/windows; the well-formed remainder still renders on /quota and /api/quota.json.feed()test fixtures in feed.test.ts/validate.test.ts updated to genuine QuotaView shape (burn + choices).Tests (laptop, bun)
pools: [null]; pool missingwindows;windows: [null];windowsas a string; malformed burn segments; well-formed view unchanged; loadFeed remainder + counts; loadFeed rejection path.Remaining in #2578 slice 2 (not this PR)
Queue task 4006. pm-stack paths have no covering CI workflow, so verification is the laptop suite above; Codex review on this PR is the merge gate.
Need help on this PR? Tag
@codesmith-botwith what you need.