Repository navigation
fix(mcpx): events resume — since=0 gap after trim + 400 on malformed cursors (#1679) - #3057
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1679 (queue task 4237, per triage task 1881's executed-probe confirmation).
(A)
events.SubscribeFrom— the gap check was gated onsince > 0, so an explicitsince=0resume after the retained history had been trimmed replayed mid-history with no gap signal (since=1 in the same state did report). The gate is dropped; the uniform formulalen(h) > 0 && h[0].Seq > since+1applies. Untrimmed since=0 still reports no gap (h[0].Seq == 1).(B)
daemon.handleEvents— thestrconv.ParseUinterror for the resume cursors was discarded, silently coercing a malformedsince/Last-Event-IDto 0 (replay everything) or MaxUint64 (replay nothing). Both parameters are now validated when present: unparseable (syntax or range) → HTTP 400 naming the parameter, before stream headers. Absent stays live-only; explicit 0 stays replay-all-retained.Tests (laptop):
go test ./internal/events/ ./internal/daemon/— both packages pass.TestExplicitZeroReportsAGapAfterTrim: history 3, 10 published, since=0 → gap=true, replay starts at seq 8.TestEventsRejectsAMalformedSince/TestEventsRejectsAMalformedLastEventID: banana / -1 / out-of-range / empty → 400 naming the parameter.TestEventsCursorBehavioursUnchanged: absent = live-only, since=0 replays all retained, since=2 replays nothing, Last-Event-ID=1 resumes after it.Out of scope per the packet: history sizing, filter semantics, MCP subscriptions/listen translation.
Need help on this PR? Tag
@codesmith-botwith what you need.