Skip to content

fix(mcpx): move sshWaitDelay into internal/defaults (#1880 follow-up to #2506) - #2559

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/3113-1880-ssh-endpoint
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/3113-1880-ssh-endpoint

Conversation

@dezren39

@dezren39 dezren39 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Follow-up fix for #1880 / PR #2506 (merged 2026-10-30T04:30Z, merge commit bb9202c9).

PR #2506's CI showed 3 failing tests in basic: test vs clean main's 2. The extra one is this PR's own: TestNoPackageRedeclaresADefault (internal/defaults) — transport_ssh.go declared const sshWaitDelay = 3 * time.Second inline, and the guard requires constants to live in internal/defaults. Main is red on that test since the merge.

This PR (single commit cf968d7a, the only commit ahead of the merge base) moves the value following the existing tsnetUpTimeout pattern:

  • defaults.json: daemon.sshWaitDelay: "3s"
  • defaults.go: Daemon.SSHWaitDelay field + defaults.SSHWaitDelay accessor
  • transport_ssh.go: var sshWaitDelay = defaults.SSHWaitDelay

Verified on the laptop at the PR head this branches from (0a9ee541 + this commit): TestNoPackageRedeclaresADefault passes; internal/defaults + internal/settings are back to exactly clean main's two failures (TestEveryDocumentationLinkResolves, TestEveryDocumentHasAChapter — pre-existing docs reds); daemon SSH tests pass.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

TestNoPackageRedeclaresADefault (internal/defaults) failed on this branch only: transport_ssh.go declared const sshWaitDelay = 3s inline. It now lives in defaults.json as daemon.sshWaitDelay with a defaults.SSHWaitDelay accessor, following the tsnetUpTimeout pattern, and transport_ssh.go reads it via a var. Verified on the laptop: the guard test passes; internal/defaults + internal/settings are back to exactly the two failures clean main has (TestEveryDocumentationLinkResolves, TestEveryDocumentHasAChapter); daemon SSH tests pass.
@dezren39
dezren39 requested a review from a team as a code owner October 30, 2026 04:33
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 02bc3798-202c-406e-af14-31c323a91f16
Commits

Reviewing files that changed from the base of the PR and between 674c4c6 and cf968d7.

Files selected for processing: 3
  • pkgs/mcpx/internal/daemon/transport_ssh.go
  • pkgs/mcpx/internal/defaults/defaults.go
  • pkgs/mcpx/internal/defaults/defaults.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T04:34:35.471814Z cf968d7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant