Repository navigation
Conversation
TestNoPackageRedeclaresADefault (internal/defaults) failed on this branch only: transport_ssh.go declared const sshWaitDelay = 3s inline. It now lives in defaults.json as daemon.sshWaitDelay with a defaults.SSHWaitDelay accessor, following the tsnetUpTimeout pattern, and transport_ssh.go reads it via a var. Verified on the laptop: the guard test passes; internal/defaults + internal/settings are back to exactly the two failures clean main has (TestEveryDocumentationLinkResolves, TestEveryDocumentHasAChapter); daemon SSH tests pass.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Follow-up fix for #1880 / PR #2506 (merged 2026-10-30T04:30Z, merge commit
bb9202c9).PR #2506's CI showed 3 failing tests in
basic: testvs clean main's 2. The extra one is this PR's own:TestNoPackageRedeclaresADefault(internal/defaults) —transport_ssh.godeclaredconst sshWaitDelay = 3 * time.Secondinline, and the guard requires constants to live ininternal/defaults. Main is red on that test since the merge.This PR (single commit
cf968d7a, the only commit ahead of the merge base) moves the value following the existingtsnetUpTimeoutpattern:defaults.json:daemon.sshWaitDelay: "3s"defaults.go:Daemon.SSHWaitDelayfield +defaults.SSHWaitDelayaccessortransport_ssh.go:var sshWaitDelay = defaults.SSHWaitDelayVerified on the laptop at the PR head this branches from (
0a9ee541+ this commit):TestNoPackageRedeclaresADefaultpasses;internal/defaults+internal/settingsare back to exactly clean main's two failures (TestEveryDocumentationLinkResolves,TestEveryDocumentHasAChapter— pre-existing docs reds); daemon SSH tests pass.Need help on this PR? Tag
@codesmith-botwith what you need.