Skip to content

feat(aggregator): per-item resolution source — unverified fixture badges + health coverage ratio (#1141) - #2425

Merged
dezren39 merged 2 commits into
mainfrom
queue/3032-1141-resolution-source
Oct 30, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/3032-1141-resolution-source

Conversation

@dezren39

@dezren39 dezren39 commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Implements the aggregator slices of #1141 (triage task 2423, queue task 3032):

  • Per-item resolution source: Source.items() in sources/live.ts now tags every served GhItem with resolution: "pool" | "projector" | "fixture" (model.ts), so fixture state is distinguishable from live data everywhere downstream instead of only in a facet-level footer string.
  • Distinct fixture rendering: itemBadge (the single badge choke point for board, roadmap, item, and program pages) renders fixture-resolved items hollow — dashed/transparent .badge.unverified — with a "· unverified" marker and a title explaining the state is fixture data, not live GitHub data.
  • Health coverage: summarizeItemCoverage in health.ts counts resolved-live vs fixture from a resolution pass; the server's existing fix(aggregator): provenance is lazily populated per process — /api/health reports "fixtures" for facets not yet loaded since boot #1267 health prime captures it from the same board items() pass that sets facet provenance, and /api/health + the /health page publish itemsCoverage (resolvedLive, fixture, total, ratio). An empty/untagged pass reports total 0 and a null ratio rather than inventing a number.
  • Tests: new test/items-resolution.test.ts (5 tests) — pool/projector/fixture tagging through items() (projector via a stub HTTP server), coverage summarizer incl. the empty case, and the unverified badge rendering.

Verification: full aggregator suite on the laptop worktree — 346 pass, 1 fail. The one failure (actions.test.ts "Snoozed by you (1)") fails identically on clean main (verified via git stash A/B) and is pre-existing, unrelated to this change. Typecheck runs in CI (no node_modules in the worktree).

The pool-backfill half of #1141 stays with the orchestrator's label-gated auto-add under #910, per the triage verdict — this PR does not close #1141's tracking of that half; it completes the aggregator slices the packet scoped.

Note: merge may be delayed by the merge-queue ejection bug #2403 (entries dropped minutes into AWAITING_CHECKS; no merge since #2233).

Refs #1141


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 29, 2026 20:55
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eaf71418-07e5-4519-8a1a-a3815ea7dbfe
Commits

Reviewing files that changed from the base of the PR and between e376012 and 02ee622.

Files selected for processing: 6
  • pm-stack/aggregator/src/health.ts
  • pm-stack/aggregator/src/model.ts
  • pm-stack/aggregator/src/render.ts
  • pm-stack/aggregator/src/server.ts
  • pm-stack/aggregator/src/sources/live.ts
  • pm-stack/aggregator/test/items-resolution.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T01:06:01.586312Z 02ee622 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Oct 29, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
…ution-source

# Conflicts:
#	pm-stack/aggregator/src/server.ts
@dezren39 dezren39 closed this Oct 30, 2026
@dezren39 dezren39 reopened this Oct 30, 2026
@dezren39 dezren39 closed this Oct 30, 2026
@dezren39 dezren39 reopened this Oct 30, 2026
@dezren39
dezren39 added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 51602b2 Oct 30, 2026
6 of 7 checks passed
@dezren39
dezren39 deleted the queue/3032-1141-resolution-source branch October 30, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

impl(aggregator/collector): Project pool resolves a minority of board/roadmap refs (172 fixture fallbacks) - raise coverage and publish the ratio

1 participant