Repository navigation
feat(aggregator): per-item resolution source — unverified fixture badges + health coverage ratio (#1141) - #2425
Conversation
…unverified, health publishes coverage ratio (#1141)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ution-source # Conflicts: # pm-stack/aggregator/src/server.ts
Implements the aggregator slices of #1141 (triage task 2423, queue task 3032):
Source.items()insources/live.tsnow tags every servedGhItemwithresolution: "pool" | "projector" | "fixture"(model.ts), so fixture state is distinguishable from live data everywhere downstream instead of only in a facet-level footer string.itemBadge(the single badge choke point for board, roadmap, item, and program pages) renders fixture-resolved items hollow — dashed/transparent.badge.unverified— with a "· unverified" marker and a title explaining the state is fixture data, not live GitHub data.summarizeItemCoverageinhealth.tscounts resolved-live vs fixture from a resolution pass; the server's existing fix(aggregator): provenance is lazily populated per process — /api/health reports "fixtures" for facets not yet loaded since boot #1267 health prime captures it from the same boarditems()pass that sets facet provenance, and/api/health+ the/healthpage publishitemsCoverage(resolvedLive, fixture, total, ratio). An empty/untagged pass reports total 0 and a null ratio rather than inventing a number.test/items-resolution.test.ts(5 tests) — pool/projector/fixture tagging throughitems()(projector via a stub HTTP server), coverage summarizer incl. the empty case, and the unverified badge rendering.Verification: full aggregator suite on the laptop worktree — 346 pass, 1 fail. The one failure (
actions.test.ts"Snoozed by you (1)") fails identically on cleanmain(verified viagit stashA/B) and is pre-existing, unrelated to this change. Typecheck runs in CI (nonode_modulesin the worktree).The pool-backfill half of #1141 stays with the orchestrator's label-gated auto-add under #910, per the triage verdict — this PR does not close #1141's tracking of that half; it completes the aggregator slices the packet scoped.
Note: merge may be delayed by the merge-queue ejection bug #2403 (entries dropped minutes into AWAITING_CHECKS; no merge since #2233).
Refs #1141
Need help on this PR? Tag
@codesmith-botwith what you need.