[dezren39]

Fixes #1623 (per triage task 1740 ruling: the governing clock is proposal.at).

Change

pm-stack/aggregator/src/tier-items.ts — proposalExpired now measures the proposal's age from d.proposal.at instead of d.updatedAt. updatedAt moves on any delegation write, so clocking from it let churn resurrect an old proposal indefinitely (and read a fresh proposal as expired when the delegation record was old). The doc comment names the clock and the reason. The 48h TTL and the supersede identity triple (item id, runId, updatedAt) are unchanged.

Tests

New regression test in pm-stack/aggregator/test/needs-user.test.ts covering both divergent cases plus the existing equal-timestamp controls:

• old proposal.at (74h) + fresh updatedAt (1h) → expired, and approve with the live triple is refused as expired;
• fresh proposal.at (1h) + old updatedAt → not expired, approve passes the gate.
• Laptop: bun test test/needs-user.test.ts — 36 passed.
• Laptop: full aggregator suite — 314 passed, 1 failed: actions.test.ts snooze-strip test, which fails identically on clean base 7248a166 (pre-existing, already filed as aggregator: actions.test.ts fails on main — applied snooze never lands in the Snoozed strip ('Snoozed by you (1)' missing) #1682; unrelated to this change).

Queue task 1867 · branch queue/1867-1623-proposal-expiry-clock

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 29221997-456f-4acf-b5cc-1e02ea2eaf25

Commits

Reviewing files that changed from the base of the PR and between 7248a16 and 4d05b19.

Files selected for processing: 2

• pm-stack/aggregator/src/tier-items.ts
• pm-stack/aggregator/test/needs-user.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-28T15:51:19.360404Z	4d05b19	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.