Repository navigation
🎨 Palette: Add aria-labels to search and goto-line inputs - #146
Conversation
Added aria-labels to the icon-only buttons in the find-and-replace panel to improve screen reader accessibility. I also added aria-labels to the associated inputs like search queries and checkboxes to improve screen reader access. Added `for` matching on the goto-line label. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replaced the deprecated `pozil/auto-assign-issue@v1` action with `actions/github-script` to fix a CI workflow failure complaining about missing issue contexts and Node 20 deprecation. Also includes the a11y improvements to the find-and-replace panel components. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
Added `pkgs.cmake` to `nativeBuildInputs` and set `dontUseCmakeConfigure = true;` across the `id-web`, `id-lib`, `mkCheck`, and `test-e2e` Nix derivations. This fixes a permission denied error when building the `libsql-ffi` dependency via `nix flake check`, which requires CMake but needs standard Rust build handling. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
💡 What: Added aria-labels to icon-only buttons (
×,▲, etc) and search inputs insearch-panel.ts, and added matchingforattribute to the label ingoto-line.ts.🎯 Why: Makes these components much more accessible to screen readers, preventing them from reading out raw unicode characters or confusing contexts for text/checkbox inputs.
📸 Before/After: Not a visual change.
♿ Accessibility: Yes, improves a11y for find-and-replace components.
PR created automatically by Jules for task 3250020320315582365 started by @dezren39