Skip to content

Update dependency vitest to v5 [SECURITY] - #140

Merged
dezren39 merged 10 commits into
mainfrom
renovate/npm-vitest-vulnerability
Oct 23, 2026
Merged

dezren39 merged 10 commits into
mainfrom
renovate/npm-vitest-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
vitest (source) ^3.2.7 → ^5.0.0 age confidence

Vitest: Path Traversal / Arbitrary File Read via @​vitest/mocker Redirect Mock

CVE-2026-84373 / GHSA-82fw-gwwq-j7x9

More information

Details

Summary

@vitest/mocker registers a redirect mock's target path without validating it
against the dev server's file-serving allowlist. An attacker who can reach the
dev server's WebSocket can register a redirect mock pointing outside the project
root; when the mocked module is requested, the plugin's load hook returns
readFile(<attacker path>) as the module source, disclosing local files.

This is exploitable without authentication only through the public
mockerPlugin / standalone interceptorPlugin exports (used by third-party dev
servers), which register the handler on Vite's unauthenticated HMR socket.
Vitest's own browser mode registers mocks over a token-authenticated RPC and
is not remotely reachable by default (see Scope).

Affected code

packages/mocker/src/node/interceptorPlugin.ts.

The load hook is the file-read sink:

if (mock.type === 'redirect') {
  return readFile(mock.redirect, 'utf-8')
}

mock.redirect is derived from client input at registration time with no
boundary check:

if (event.type === 'redirect') {
  const redirectUrl = new URL(event.redirect)
  event.redirect = join(server.config.root, redirectUrl.pathname)
}
registry.register(event)

There is no server.fs.allow / server.fs.deny check and no assertion that the
resolved path stays within the project root.

Registration paths and trust boundaries
  • Public mockerPlugin / interceptorPlugin (unauthenticated). In
    configureServer, the plugin registers server.ws.on('vitest:interceptor:register', …)
    on Vite's HMR WebSocket. That socket performs no token, Origin, or same-origin
    check, so any client that can reach it can register a redirect mock. This is
    the path the "unauthenticated" impact applies to.
  • Vitest browser mode (authenticated). Mocks register over the browser RPC
    (registerMock), which sits behind a per-run token (isValidApiRequest, a
    random api.token). The interceptor's configureServer socket is not used for
    registration here (in v5 it does not run at all, as the plugin is injected per
    environment). The same missing boundary check exists on the authenticated RPC
    path, but reaching it requires the token, so it is not a remote-unauthenticated
    read.
Path handling

new URL(redirect).pathname combined with join(root, pathname) does not
confine reads to the root:

  • Special/hierarchical schemes (file:, http:) are normalized by WHATWG URL,
    so .. segments are collapsed and the result stays under the root. Payloads of
    the form file:///../../etc/passwd do not escape.
  • A non-special (opaque) scheme preserves .. in pathname, so
    join(root, "../../…/etc/passwd") resolves outside the root and reads an
    arbitrary file.

Even without escaping the root, the missing server.fs check allows reading any
in-root file the dev server would otherwise refuse to serve (for example an
in-root .env or source that is denied by server.fs.deny).

Scope / preconditions
  • This is a development-server issue. The dev server binds to localhost by
    default and is not reachable from the network unless the developer exposes it
    (server.host / 0.0.0.0, a LAN bind, or a proxy).
  • A raw (non-browser) client against a reachable server bypasses browser origin
    and CORS protections entirely and can both register the mock and read the
    response.
  • A browser-based drive-by against a localhost server is substantially mitigated
    by Vite defaults: the default CORS origin allowlist is limited to localhost
    origins, and server.allowedHosts blocks DNS-rebinding, so a cross-origin page
    cannot read the file contents back.
Impact

Disclosure of local files readable by the dev-server process (source, in-root
.env/secrets, and, via the opaque-scheme payload, files outside the project
root). No integrity or availability impact.

Affected versions

Present since @vitest/mocker was introduced.

  • Affected: @vitest/mocker >= 2.1.0 (shipped in vitest and
    @vitest/browser >= 2.1.0), through 4.1.x and the 5.0.0 pre-releases.
  • Fixed: Vitest 4.1.11 and 5.0.0. Older majors (2.1.x, 3.x) are not
    maintained and are not planned to receive the fix.
Fix

Validate the resolved redirect target against Vite's file-serving allowlist
(isFileLoadingAllowed) before registering it, at every registration site, and
stop registering the interceptor WebSocket events in Vitest's browser mode
(mocks there flow through the authenticated RPC).

Severity

  • CVSS Score: 5.9 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:N

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Release Notes

vitest-dev/vitest (vitest)

v5.0.5

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v5.0.4

Compare Source

   🚀 Features
   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

v5.0.3

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v5.0.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v5.0.1

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v5.0.0

Compare Source

Vitest 5 is officially out! This release focuses on performance and brings a lot of new features while fixing long-standing bugs. See our blog post for the official announcement.

   🚨 Breaking Changes
   🚀 Features

[!IMPORTANT]
✂ PR body was truncated to here.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested review from a team and dezren39 as code owners September 10, 2026 17:17
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 605b1ae to b0f34a1 Compare September 11, 2026 00:38
@renovate renovate Bot changed the title Update dependency vitest to v5 [SECURITY] Update dependency vitest to v4 [SECURITY] Sep 11, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from b0f34a1 to 3ffc5fe Compare September 15, 2026 12:48
@renovate renovate Bot changed the title Update dependency vitest to v4 [SECURITY] Update dependency vitest to v5 [SECURITY] Sep 15, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 3ffc5fe to a9cca7e Compare September 16, 2026 01:41
@renovate renovate Bot changed the title Update dependency vitest to v5 [SECURITY] Update dependency vitest to v4 [SECURITY] Sep 16, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from a9cca7e to 3950899 Compare September 16, 2026 12:29
@renovate renovate Bot changed the title Update dependency vitest to v4 [SECURITY] Update dependency vitest to v5 [SECURITY] Sep 16, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 3950899 to 6cd9f28 Compare September 17, 2026 00:57
@renovate renovate Bot changed the title Update dependency vitest to v5 [SECURITY] Update dependency vitest to v4 [SECURITY] Sep 17, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 6cd9f28 to a5e62b5 Compare September 17, 2026 20:52
@renovate renovate Bot changed the title Update dependency vitest to v4 [SECURITY] Update dependency vitest to v5 [SECURITY] Sep 17, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from a5e62b5 to bf751d2 Compare September 18, 2026 03:03
@renovate renovate Bot changed the title Update dependency vitest to v5 [SECURITY] Update dependency vitest to v4 [SECURITY] Sep 18, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from bf751d2 to 026b055 Compare September 18, 2026 19:37
@renovate renovate Bot changed the title Update dependency vitest to v4 [SECURITY] Update dependency vitest to v5 [SECURITY] Sep 18, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 026b055 to 947c552 Compare September 19, 2026 00:54
@renovate renovate Bot changed the title Update dependency vitest to v5 [SECURITY] Update dependency vitest to v4 [SECURITY] Sep 19, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 947c552 to 622eae6 Compare September 24, 2026 01:47
@renovate renovate Bot changed the title Update dependency vitest to v4 [SECURITY] Update dependency vitest to v5 [SECURITY] Sep 24, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 622eae6 to 4ece4f1 Compare September 25, 2026 12:30
@renovate renovate Bot changed the title Update dependency vitest to v5 [SECURITY] Update dependency vitest to v4 [SECURITY] Sep 25, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 4ece4f1 to 3dae6e8 Compare October 1, 2026 15:35
@renovate renovate Bot changed the title Update dependency vitest to v4 [SECURITY] Update dependency vitest to v5 [SECURITY] Oct 1, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 3dae6e8 to a20373d Compare October 1, 2026 19:10
@renovate renovate Bot changed the title Update dependency vitest to v5 [SECURITY] Update dependency vitest to v4 [SECURITY] Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7f9a0930-f74f-4523-a4ee-94e56a13c12d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

The web package updates the Vitest development dependency range from ^3.2.7 to ^4.1.11.

Changes: Web Test Dependency

Layer / File(s) Summary
Update Vitest version range
pkgs/id/web/package.json
The declared Vitest development dependency range changes from ^3.2.7 to ^4.1.11.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: 🔵 Low · up to d41f1

The Nix unit check still uses Vitest 3.2.7, so it will not validate this upgrade. Regenerate its dependency source before relying on that check; the issue is limited to test confidence.

Architecture risk: 🔵 Low · up to d41f1

The change affects 1 system.

Changed systems: pkgs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pkgs (ui) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pkgs/id/web/package.json: The vitest devDependency range changed from ^3.2.7 to ^4.1.11.
Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the Vitest dependency update and its security purpose. It matches the main change in the pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from a20373d to c1556ad Compare October 5, 2026 17:13
@renovate renovate Bot changed the title chore(deps): update dependency vitest to v5 [security] chore(deps): update dependency vitest to v4 [security] Oct 12, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 9f24753 to 6127bcd Compare October 12, 2026 10:11
@renovate renovate Bot changed the title chore(deps): update dependency vitest to v4 [security] chore(deps): update dependency vitest to v5 [security] Oct 12, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 6127bcd to 5ffb141 Compare October 12, 2026 10:23
@renovate renovate Bot changed the title chore(deps): update dependency vitest to v5 [security] chore(deps): update dependency vitest to v4 [security] Oct 12, 2026
@renovate
renovate Bot force-pushed the renovate/npm-vitest-vulnerability branch from 5ffb141 to 0fc1acb Compare October 12, 2026 11:07
@renovate renovate Bot changed the title chore(deps): update dependency vitest to v4 [security] chore(deps): update dependency vitest to v5 [security] Oct 12, 2026
@renovate

renovate Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant