Repository navigation
fix(opencode): remove shadowed duplicate cline-pass provider block - #1311
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Closes #1308. Removes the shadowed duplicate
"cline-pass"provider block from.opencode/opencode.jsonc. Single file, +3/−82 (the +3 is a comment at the surviving block recording the dedup).Which block was effective
The second block (the one this PR keeps, formerly at line 5124). The fork's config loader —
packages/core/src/config.tsin developing-today/opencode — parses config withjsonc-parser'sparse(), which builds a plain object in document order: for a duplicate key, the later value wins. The first block (formerly line 4812) was dead config.Whether the effective catalog changes
It does not. The two blocks turned out to be byte-identical — same
npm/name/options, same 18 models in the same order with identical entries (verified by direct text diff of the two block bodies, and deep-equality after parsing). So the "union" the issue asks for is just the single 18-model catalog, and nothing was meaningfully shadowed: no model existed only in the dead block.(Note: the issue said 19 vs 18 entries; the byte-level count on current main is 18 vs 18, matching the "cline-pass 18" figure PR #1304 verified after the sync.)
The change
Verification (programmatic, string-aware JSONC parse)
"cline-pass"key remains at provider level (pairs-preserving parse, not a text count).cline-pass/...references resolve: the threeexperimental.model_routestargets —deepseek-flash-plan→cline-pass/deepseek-v4.1-flash,deepseek-pro-plan→cline-pass/deepseek-v4-pro,glm-flash-plan→cline-pass/glm-5.3-flash— plus every othercline-pass/<model>string in the config (18 distinct, 0 unresolved).Need help on this PR? Tag
@codesmith-botwith what you need.