Skip to content

fix(opencode): remove shadowed duplicate cline-pass provider block - #1311

Merged
dezren39 merged 1 commit into
mainfrom
fix/cline-pass-duplicate-1308
Oct 27, 2026
Merged

dezren39 merged 1 commit into
mainfrom
fix/cline-pass-duplicate-1308

Conversation

@dezren39

@dezren39 dezren39 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Closes #1308. Removes the shadowed duplicate "cline-pass" provider block from .opencode/opencode.jsonc. Single file, +3/−82 (the +3 is a comment at the surviving block recording the dedup).

Which block was effective

The second block (the one this PR keeps, formerly at line 5124). The fork's config loader — packages/core/src/config.ts in developing-today/opencode — parses config with jsonc-parser's parse(), which builds a plain object in document order: for a duplicate key, the later value wins. The first block (formerly line 4812) was dead config.

Whether the effective catalog changes

It does not. The two blocks turned out to be byte-identical — same npm/name/options, same 18 models in the same order with identical entries (verified by direct text diff of the two block bodies, and deep-equality after parsing). So the "union" the issue asks for is just the single 18-model catalog, and nothing was meaningfully shadowed: no model existed only in the dead block.

(Note: the issue said 19 vs 18 entries; the byte-level count on current main is 18 vs 18, matching the "cline-pass 18" figure PR #1304 verified after the sync.)

The change

  • Deleted the first (shadowed) block — 82 lines — leaving the effective block in place, per the issue's "place it where the effective block sat".
  • Added a 3-line dated comment at the surviving block so the duplicate isn't reintroduced.

Verification (programmatic, string-aware JSONC parse)

  • File parses; exactly one "cline-pass" key remains at provider level (pairs-preserving parse, not a text count).
  • The surviving block's model set equals the union of the two originals (18), and every model entry is verbatim-identical to the originals.
  • Under the loader's last-wins semantics, the entire parsed config is deep-identical before and after — a pure dedup with zero runtime effect.
  • All cline-pass/... references resolve: the three experimental.model_routes targets — deepseek-flash-plan → cline-pass/deepseek-v4.1-flash, deepseek-pro-plan → cline-pass/deepseek-v4-pro, glm-flash-plan → cline-pass/glm-5.3-flash — plus every other cline-pass/<model> string in the config (18 distinct, 0 unresolved).

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 27, 2026 06:01
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d1355eb1-b877-419f-a5c4-df7d7205d96b
Commits

Reviewing files that changed from the base of the PR and between dd4ee06 and c40b6c5.

Files selected for processing: 1
  • .opencode/opencode.jsonc
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T06:03:17.825482Z c40b6c5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit ff5a86a into main Oct 27, 2026
4 of 5 checks passed
@dezren39
dezren39 deleted the fix/cline-pass-duplicate-1308 branch October 27, 2026 06:07
dezren39 added a commit that referenced this pull request Nov 2, 2026
dezren39 added a commit that referenced this pull request Nov 2, 2026
…, tiered expectedShare #1306, nested routes + shim #1311, nodeModules hash refresh #1417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config hygiene: duplicate "cline-pass" provider blocks in opencode.jsonc

1 participant