Skip to content

Preserved branch: probe/laneA-tagkey — decision needed (merge / cherry-pick / drop) #3588

Closed

Description

@dezren39

Preserved branch from the laptop worktree cleanup of 2026-11-01.

  • Branch: probe/laneA-tagkey
  • Verified HEAD on origin: c1c748ecf5c9681bf9eecd2819f40fab4a2fd89f
  • Provenance: this branch holds work that existed only in a local worktree on the laptop (unique commits and/or a rescue commit of uncommitted work: "rescue: preserve uncommitted work from worktree cleanup 2026-11-01"). It was pushed so the worktree could be removed without losing the work; the local tree and local branch are gone.
  • Decision needed: merge it, cherry-pick from it, or drop the branch. Nothing else references it; this issue is the record of what it holds.

Activity

  1. developing-today commented on Nov 1, 2026

    @developing-today
    Contributor
  2. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

  3. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · done — preserved branch dropped, not deleted

    What the branch holds

    probe/laneA-tagkey is a single commit, c1c748e ("rescue: preserve uncommitted work from worktree cleanup 2026-11-01"), +15 lines in pkgs/id/src/tags.rs: one probe test probe_decode_alpha_key_rejects_trailing_fourth_field asserting that decode_alpha_key/decode_omega_key reject a 4-field key (assert!(…is_err())), built with raw TupleEncoder::string.

    Why it is superseded on current main (1e3763fa)

    • Main already carries test_decode_alpha_key_rejects_four_fields and test_decode_omega_key_rejects_four_fields (pkgs/id/src/tags.rs ~L2099–L2114), landed in fix(design-code): repoint :18745 legs to antigravity-direct :18751 (#1413, unblocks opencode#1409) #4626 on 2026-11-02 — one day after this branch was preserved.
    • They cover the same behaviour more strictly: 4-field keys are built with encode_smart, and the tests assert the error message contains expected 3 rather than merely is_err().
    • Verified on clean main: cargo test --lib rejects_four_fields → 2 passed, 0 failed. The branch adds nothing unique.
    • No open/closed PR references the branch, and no other live queue task or PR owns this work.

    State

    • Issue closed as completed with this evidence; the branch probe/laneA-tagkey is not deleted, per instructions.
    • No blockers remain; no follow-up work is needed for this decision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority/lowNice to have; do when convenient

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions