Skip to content

feat(core): flip embeddings registration to native-onnx backend (#1554 step 3) - #1690

Merged
dezren39 merged 1 commit into
mainfrom
queue/9487-1554-native-flip
Nov 5, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/9487-1554-native-flip

Conversation

@dezren39

@dezren39 dezren39 commented Nov 5, 2026

Copy link
Copy Markdown

Queue task 9487 (repo-health-opencode-pilot). Step 3 of #1554 only; step 4 is filed separately as #1689 / queue task 9823.

Change

  • EMBEDDING_MODELS[0] (local-embed/snowflake-arctic-embed-m-v2.0) now names backend: { kind: "native-onnx", snapshotEnv: "LOCAL_EMBED_SNAPSHOT", snapshotDir: "~/.cache/huggingface/hub/models--Snowflake--snowflake-arctic-embed-m-v2.0/snapshots/95c2741480856aa9666782eb4afe11959938017f", maxTokens: 8192 } — the same env var and default snapshot the :18752 sidecar service uses; the backend throws loudly when the snapshot is missing. HTTP registration data (baseURL/baseURLEnv) stays intact for step 4.
  • embeddings-native.test.ts pin updated from HTTP default to the native default.

Predecessors revalidated fresh before work: #1567 CLOSED/COMPLETED, #1583 CLOSED/COMPLETED, PR #1617 MERGED, PR #1632 MERGED.

Verification (laptop, sidecar stopped)

  • bun test packages/core/test/embeddings.test.ts packages/core/test/embeddings-native.test.ts (LD_LIBRARY_PATH per embeddings-native.ts header): 20 pass, 0 fail — including native parity bit-identical to the sidecar fixture at 768-d, Matryoshka 256-d, and the fix(core): native embeddings load failure is cached forever — one failed first load bricks the backend until restart #1567 load-eviction test.
  • Live round-trip through the embeddings door (Embeddings.Service with the default registration) with no listener on :18752 confirmed: index 2 docs at 768-d, query at 768-d and 256-d, mixed-length batch of 4 untruncated, retrieval ordering correct (cos query↔QCD doc 0.7337 > cos query↔fox doc 0.1337).

Refs #1554. Step 4 (sidecar retirement): #1689.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant