Repository navigation
feat(core): flip embeddings registration to native-onnx backend (#1554 step 3) - #1690
Merged
Merged
Conversation
This was referenced Nov 5, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue task 9487 (repo-health-opencode-pilot). Step 3 of #1554 only; step 4 is filed separately as #1689 / queue task 9823.
Change
EMBEDDING_MODELS[0](local-embed/snowflake-arctic-embed-m-v2.0) now namesbackend: { kind: "native-onnx", snapshotEnv: "LOCAL_EMBED_SNAPSHOT", snapshotDir: "~/.cache/huggingface/hub/models--Snowflake--snowflake-arctic-embed-m-v2.0/snapshots/95c2741480856aa9666782eb4afe11959938017f", maxTokens: 8192 }— the same env var and default snapshot the :18752 sidecar service uses; the backend throws loudly when the snapshot is missing. HTTP registration data (baseURL/baseURLEnv) stays intact for step 4.embeddings-native.test.tspin updated from HTTP default to the native default.Predecessors revalidated fresh before work: #1567 CLOSED/COMPLETED, #1583 CLOSED/COMPLETED, PR #1617 MERGED, PR #1632 MERGED.
Verification (laptop, sidecar stopped)
bun test packages/core/test/embeddings.test.ts packages/core/test/embeddings-native.test.ts(LD_LIBRARY_PATH per embeddings-native.ts header): 20 pass, 0 fail — including native parity bit-identical to the sidecar fixture at 768-d, Matryoshka 256-d, and the fix(core): native embeddings load failure is cached forever — one failed first load bricks the backend until restart #1567 load-eviction test.Refs #1554. Step 4 (sidecar retirement): #1689.