Repository navigation
Conversation
Triage #1496: the main ast-grep rule scan reported 32 error-level diagnostics with nothing running it. - Exclude the vendored packages/core/src/database/drizzle/** tree via --globs in lint:effect-patterns (upstream star-import style, already /* oxlint-disable */; rewriting would diverge the vendored copy). - Fix 14 first-party sites: die with new Error (4), drop vacuous JSON.parse casts (5), drop createServer alias (1), named platform imports in cross-spawn-spawner (2), dedicated import type for the colliding SDK type (1), and add a Check Effect patterns step to test.yml so new violations fail CI. - Suppress 3 sites with rationale at the site: schema Messaging alias (name taken by the module self-namespace export) and 2 platform-node star imports (colliding layer exports, aliases banned, barrel unusable under workerd). Verification: bun run lint:effect-patterns exits 0; test:lint-rules 6/6 and test:effect-simplification-rules 10/10 pass; a synthetic star-import violation fails the scan; util typechecks clean (core typecheck still reports the pre-existing model-route.ts TS6133). Refs #1496
…ue/7181-1496-effect-patterns
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Open
4 tasks
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by the git hygiene sweep (issue #1371) from previously-unpushed work found in the laptop worktree ~/git/fleet/7181.
The branch carries commit 35a27a4 ("fix(ci): disposition effect-patterns violations and wire scan into CI") merged with origin/effect-patterns-triage at 863e6cd. The sweep pushed the branch and opened this PR; it did not author or modify the work.
Refs #1496
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.