Skip to content

fix(ci): check:proto-reads fails on main — variant.ts guarded read is unlisted and its pre-#878 allowlist entry is stale #896

Closed

Description

@dezren39

Problem

bun run check:proto-reads (the #865 prototype-chain regression gate, run in CI on Linux in .github/workflows/test.yml, "Check prototype-chain reads are dispositioned") fails on current main 580c277358. The gate's allowlist was written against the pre-#878 shape of variant.ts; PR #878 then changed that read to a multiline Object.hasOwn guard, and PR #883 (the #865 gate itself) merged afterwards carrying the now-stale entry. The guarded read is correct — the gate's bookkeeping is what is broken — so every CI run of the test workflow on main fails this step until the allowlist is updated.

Evidence (main 580c277358, verified this run)

Why it matters

A regression gate that is red on main trains everyone to ignore it — the exact failure mode #865/#833 built it to prevent — and it fails the Linux test workflow step for unrelated PRs until fixed. The fix is bookkeeping only; the underlying prototype-chain read is already correctly guarded.

Acceptance criteria

Activity

  1. added
    kind/ciCI/CD pipelines, workflows, and build automation
    task/small-fixQueue packet kind: bounded fix with reproduction and targeted tests
    source/creatorFiled by the new-issue-creator job
    on Oct 29, 2026
  2. developing-today commented on Oct 29, 2026

    @developing-today
  3. added
    priority/highImportant and time-sensitive
    queue/queuedHas a queued task in the Supabase agent queue
    area/ciCI, workflows, and build infrastructure
    effort/xsTrivial: expected under 30 minutes of work
    on Oct 29, 2026
  4. dezren39 commented on Oct 29, 2026

    @dezren39
    Author

    🤖 Agent note · filed

  5. added
    work/assignedAn agent holds this item via the queue (claimed task)
    queue/claimedA queue worker has claimed the task for this item
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Oct 29, 2026
  6. 3 remaining items

  7. added
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    status/parkedDeliberately paused with a recorded resume condition
    and removed
    queue/claimedA queue worker has claimed the task for this item
    on Oct 29, 2026
  8. dezren39 commented on Oct 29, 2026

    @dezren39
    Author

    🤖 Agent note · parked — CI queued

  9. added
    queue/claimedA queue worker has claimed the task for this item
    and removed
    status/parkedDeliberately paused with a recorded resume condition
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Oct 29, 2026
  10. removed
    queue/claimedA queue worker has claimed the task for this item
    work/assignedAn agent holds this item via the queue (claimed task)
    on Oct 29, 2026
  11. dezren39 commented on Oct 29, 2026

    @dezren39
    Author

    Resumed parked task 3525: PR #897 rechecked fresh — all 4 required checks SUCCESS (basic typecheck, basic affected packages, basic unit linux/windows), check-standards and check-compliance SUCCESS on their latest runs, Codex review completed on head a19a9ae with no findings. Squash-merged #897 (e030d19); #896 closed. The one-line allowlist fix restores bun run check:proto-reads on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/ciCI, workflows, and build infrastructureeffort/xsTrivial: expected under 30 minutes of workkind/ciCI/CD pipelines, workflows, and build automationpriority/highImportant and time-sensitivesource/creatorFiled by the new-issue-creator jobstatus:donetask/small-fixQueue packet kind: bounded fix with reproduction and targeted tests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions